Bug 49666 – [Gtk] "CRITICAL **: msg_got_headers_cb: assertion `entry' failed" when using HTTP cache

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Sergio Villar Senin]

People reported load errors when this critical is shown. It seems that clearing the cache helps, but it reappears later after some more browsing

[Sergio Villar Senin]

Created attachment 74120 [details]
Fix for the bug

The assumption was wrong. We were assuming that the HTTP cache was the only one generating conditional requests to the server for its cached resources.

WebKit has its own in memory resource cache. It is capable of detecting when a resource needs to be revalidated and thus it can create conditional requests by itself. The problem was that the cache code was not considering that possibility, cache clients should be allowed to issue their own conditional requests. In those cases the cache should not do anything special, just return the resource as provided by libsoup.

[Sergio Villar Senin]

Adding Xan as he told me about this bug

[Xan Lopez]

Comment on attachment 74120 [details]
Fix for the bug

>+        taken that into account by taking the assumption that any possible
taking that into account... making the assumption?
>+        conditional request was always generated by itself.
>+
>+        * platform/network/soup/cache/webkit/soup-cache.c:
>+        (webkit_soup_cache_entry_remove): added an assertion
>+        (msg_got_headers_cb):
>+

Rest makes sense to me, thanks for tracking it down.

[Sergio Villar Senin]

Created attachment 74210 [details]
Fix for the bug

[Eric Seidel (no email)]

Comment on attachment 74120 [details]
Fix for the bug

Cleared Xan Lopez's review+ from obsolete attachment 74120 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[Xan Lopez]

Comment on attachment 74210 [details]
Fix for the bug

r=me

[Xan Lopez]

Comment on attachment 74210 [details]
Fix for the bug

Clearing flags, seems this got stuck in cq.

[Xan Lopez]

Comment on attachment 74210 [details]
Fix for the bug

Hi?

[WebKit Commit Bot]

Comment on attachment 74210 [details]
Fix for the bug

Clearing flags on attachment: 74210

Committed r72378: <http://trac.webkit.org/changeset/72378>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.