The #defines for ENABLE_TOUCH_EVENT seem a bit chaotic. It looks like the library would not compile.
Created attachment 74114 [details] Patch
Comment on attachment 74114 [details] Patch LGTM, r+. Laszlo
The commit-queue encountered the following flaky tests while processing attachment 74114 [details]: fast/loader/recursive-before-unload-crash.html fast/dom/onerror-img.html Please file bugs against the tests. These tests were authored by beidson@apple.com and eric@webkit.org. The commit-queue is continuing to process your patch.
Comment on attachment 74114 [details] Patch Rejecting patch 74114 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2 Last 500 characters of output: itBuild/Debug/WebProcess.app /Projects/CommitQueue/WebKitBuild/Debug/WebKit2.framework ** BUILD FAILED ** The following build commands failed: WebKit2: CompileC /Projects/CommitQueue/WebKitBuild/WebKit2.build/Debug/WebKit2.build/Objects-normal/x86_64/WebKeyboardEvent.o /Projects/CommitQueue/WebKit2/Shared/WebKeyboardEvent.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 (1 failure) Use of uninitialized value $_[0] in join or string at /System/Library/Perl/5.10.0/File/Spec/Unix.pm line 81. Full output: http://queues.webkit.org/results/6178063
Comment on attachment 74114 [details] Patch cq+, this patch has nothing to do with the build failure on Mac.
Comment on attachment 74114 [details] Patch Clearing flags on attachment: 74114 Committed r72305: <http://trac.webkit.org/changeset/72305>
All reviewed patches have been landed. Closing bug.
Odd. I'm not sure how the cq got confused like that. It should have tried to build again and failed and then not commented. I've not seen it have a false-positive build failure in a long long time.