Bug 49664 - [Qt] [WK2] WebKit 2 would not compile for Qt without ENABLE_TOUCH_EVENT
Summary: [Qt] [WK2] WebKit 2 would not compile for Qt without ENABLE_TOUCH_EVENT
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P5 Trivial
Assignee: Benjamin Poulain
Keywords: Qt, QtTriaged
Depends on:
Reported: 2010-11-17 07:17 PST by Benjamin Poulain
Modified: 2010-11-18 11:49 PST (History)
2 users (show)

See Also:

Patch (1.94 KB, patch)
2010-11-17 07:54 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2010-11-17 07:17:00 PST
The #defines for ENABLE_TOUCH_EVENT seem a bit chaotic. It looks like the library would not compile.
Comment 1 Benjamin Poulain 2010-11-17 07:54:51 PST
Created attachment 74114 [details]
Comment 2 Laszlo Gombos 2010-11-17 08:37:49 PST
Comment on attachment 74114 [details]

LGTM, r+. Laszlo
Comment 3 WebKit Commit Bot 2010-11-18 01:05:47 PST
The commit-queue encountered the following flaky tests while processing attachment 74114 [details]:


Please file bugs against the tests.  These tests were authored by beidson@apple.com and eric@webkit.org.  The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2010-11-18 06:34:21 PST
Comment on attachment 74114 [details]

Rejecting patch 74114 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2
Last 500 characters of output:
itBuild/Debug/WebProcess.app /Projects/CommitQueue/WebKitBuild/Debug/WebKit2.framework


The following build commands failed:
	CompileC /Projects/CommitQueue/WebKitBuild/WebKit2.build/Debug/WebKit2.build/Objects-normal/x86_64/WebKeyboardEvent.o /Projects/CommitQueue/WebKit2/Shared/WebKeyboardEvent.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
(1 failure)

Use of uninitialized value $_[0] in join or string at /System/Library/Perl/5.10.0/File/Spec/Unix.pm line 81.

Full output: http://queues.webkit.org/results/6178063
Comment 5 Benjamin Poulain 2010-11-18 07:11:22 PST
Comment on attachment 74114 [details]

cq+, this patch has nothing to do with the build failure on Mac.
Comment 6 WebKit Commit Bot 2010-11-18 10:09:26 PST
Comment on attachment 74114 [details]

Clearing flags on attachment: 74114

Committed r72305: <http://trac.webkit.org/changeset/72305>
Comment 7 WebKit Commit Bot 2010-11-18 10:09:31 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Eric Seidel (no email) 2010-11-18 11:49:33 PST
Odd.  I'm not sure how the cq got confused like that.  It should have tried to build again and failed and then not commented.  I've not seen it have a false-positive build failure in a long long time.