Bug 49660 - Clear the speech input mock explicitly before each test.
Summary: Clear the speech input mock explicitly before each test.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-17 06:34 PST by Satish Sampath
Modified: 2010-11-17 09:41 PST (History)
2 users (show)

See Also:

Attachments
Patch (10.71 KB, patch)
2010-11-17 06:40 PST, Satish Sampath 		no flags Details | Formatted Diff | Diff
Patch (9.45 KB, patch)
2010-11-17 06:52 PST, Satish Sampath 		jorlow: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Satish Sampath 2010-11-17 06:34:21 PST 
In DRT, the speech input mock is currently held by LayoutTestController and when a mock result is set the value stays as is across all subsequent tests until overwritten. In preparation for a future CL where we'll be having a list of mock results instead of just 1, I'm adding a 'clearResults' method to the mock and invoking it before each test. This also required moving the mock from LayoutTestController to WebViewHost because WebViewHost::reset() is the place to do this type of work.
Comment 1 Satish Sampath 2010-11-17 06:40:18 PST 
Created attachment 74104 [details]
Patch
Comment 2 Satish Sampath 2010-11-17 06:52:42 PST 
Created attachment 74107 [details]
Patch
Comment 3 Jeremy Orlow 2010-11-17 07:10:54 PST 
Comment on attachment 74107 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74107&action=review

r=me

> WebKitTools/DumpRenderTree/chromium/WebViewHost.cpp:1174
> +    if (m_speechInputControllerMock.get())

don't need .get()
Comment 4 Satish Sampath 2010-11-17 07:17:36 PST 
Committed r72206: <http://trac.webkit.org/changeset/72206>
Comment 5 Mihai Parparita 2010-11-17 09:39:52 PST 
Committed r72214: <http://trac.webkit.org/changeset/72214>
Comment 6 Mihai Parparita 2010-11-17 09:41:31 PST 
(In reply to comment #5)
> Committed r72214: <http://trac.webkit.org/changeset/72214>

Oops, that wasn't supposed to happen (ChangeLog got merged wrong, didn't notice before using webkit-patch land)