Bug 49656 - [v8] fast/css/getFloatValueForUnit.html fails since http://trac.webkit.org/changeset/72189
Summary: [v8] fast/css/getFloatValueForUnit.html fails since http://trac.webkit.org/ch...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-17 05:28 PST by anton muhin
Modified: 2010-11-18 08:12 PST (History)
5 users (show)

See Also:

Attachments
[PATCH] Suggested fix (3.73 KB, patch)
2010-11-18 06:05 PST, Alexander Pavlov (apavlov) 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description anton muhin 2010-11-17 05:28:14 PST 
Alexander is tracking it down, for now just disabling the test
Comment 1 Alexander Pavlov (apavlov) 2010-11-17 09:19:09 PST 
Seems related to the bug 33193 patch by tkent@chromium.org, which explicitly cancels HasIndexGetter for WebKitCSSTransformValue (CodeGeneratorV8.pm). The code that manifests the issue is (element.style having "-webkit-transform: rotate(90deg)"):

element.style.getPropertyCSSValue("-webkit-transform")[0][0] returns "undefined", while Safari returns the property CSSPrimitiveValue instance on which you can invoke e.g. getFloatValue(CSSPrimitiveValue.CSS_RAD).

I believe tkent@chromium.org may have some insight in this regard.
Comment 2 Kent Tamura 2010-11-18 00:34:18 PST 
I remember V8WebKitCSSTransformValue class inherited something (maybe V8CSSValueList?) at that time and no need to implement index getter functions.  But with the current CodeGeneratorV8.pm, V8WebKitCSSTransformValue inherits nothing.  So my hack in Bug 33193 is not effective now.

We should remove the change of Bug 33193, and implement index getter functions for V8WebKitCSSTransformValue.
Comment 3 Alexander Pavlov (apavlov) 2010-11-18 06:05:59 PST 
Created attachment 74229 [details]
[PATCH] Suggested fix
Comment 4 anton muhin 2010-11-18 06:19:53 PST 
Comment on attachment 74229 [details]
[PATCH] Suggested fix

LGTM, but I cannot r+
Comment 5 Alexander Pavlov (apavlov) 2010-11-18 08:12:19 PST 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       LayoutTests/ChangeLog
        M       LayoutTests/platform/chromium/test_expectations.txt
        M       WebCore/ChangeLog
        M       WebCore/bindings/scripts/CodeGeneratorV8.pm
Committed r72290