Bug 49640 - Rebaseline server: compute diffs client-side
Summary: Rebaseline server: compute diffs client-side
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mihai Parparita
URL:
Keywords:
Depends on:
Blocks: 47761
  Show dependency tree / graph
 
Reported: 2010-11-16 19:21 PST by Mihai Parparita
Modified: 2010-11-17 09:43 PST (History)
1 user (show)

See Also:

Attachments
Patch (7.18 KB, patch)
2010-11-16 19:23 PST, Mihai Parparita 		tony: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Parparita 2010-11-16 19:21:24 PST 
Rebaseline server: compute diffs client-side
Comment 1 Mihai Parparita 2010-11-16 19:23:07 PST 
Created attachment 74078 [details]
Patch
Comment 2 Tony Chang 2010-11-17 08:53:36 PST 
Comment on attachment 74078 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74078&action=review

> WebKitTools/Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:241
> +    if (currentExpectedImageTest == currentActualImageTest &&
> +        currentExpectedImageTest == testName) {

Nit: WebKit style is to put the && on the left of the second line.
Comment 3 Mihai Parparita 2010-11-17 09:43:00 PST 
(In reply to comment #2)
> Nit: WebKit style is to put the && on the left of the second line.

Fixed before landing. This got landed as http://trac.webkit.org/changeset/72214, but due to a bad merge in the ChangeLog (my entry didn't end up at the top) didn't get attached to this bug in the commit.