RESOLVED FIXED Bug 49634
Make overflow guards in WTF::String::utf8 explicit 
https://bugs.webkit.org/show_bug.cgi?id=49634
Summary Make overflow guards in WTF::String::utf8 explicit
David Kilzer (:ddkilzer)
Reported 2010-11-16 17:27:45 PST
Make overflow guards in WTF::String::utf8 explicit
Attachments
Patch (2.11 KB, patch)
2010-11-16 17:30 PST, David Kilzer (:ddkilzer) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2010-11-16 17:30:49 PST
Created attachment 74071 [details] Patch
David Kilzer (:ddkilzer)
Comment 2 2010-11-16 17:31:29 PST
<rdar://problem/8675768>
Darin Adler
Comment 3 2010-11-16 18:01:28 PST
Comment on attachment 74071 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74071&action=review > JavaScriptCore/wtf/text/WTFString.cpp:700 > + if (length > numeric_limits<unsigned>::max() / 3) If we changed the type of the local variable length to size_t instead of unsigned, then this could just check against size_t instead of unsigned, giving us a higher limit on 64-bit platforms.
David Kilzer (:ddkilzer)
Comment 4 2010-11-16 18:08:04 PST
(In reply to comment #3) > (From update of attachment 74071 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=74071&action=review > > > JavaScriptCore/wtf/text/WTFString.cpp:700 > > + if (length > numeric_limits<unsigned>::max() / 3) > > If we changed the type of the local variable length to size_t instead of unsigned, then this could just check against size_t instead of unsigned, giving us a higher limit on 64-bit platforms. Thanks. I filed Bug 49637.
David Kilzer (:ddkilzer)
Comment 5 2010-11-17 08:39:20 PST
Committed r72209: <http://trac.webkit.org/changeset/72209>
Note You need to log in before you can comment on or make changes to this bug.