RESOLVED FIXED 49630
Move Position::EditingBoundaryCrossingRule to a new header file
https://bugs.webkit.org/show_bug.cgi?id=49630
Summary Move Position::EditingBoundaryCrossingRule to a new header file
Benjamin (Ben) Kalman
Reported 2010-11-16 15:56:58 PST
Move Position::EditingBoundaryCrossingRule to a new header file
Attachments
Patch (12.07 KB, patch)
2010-11-16 15:59 PST, Benjamin (Ben) Kalman
no flags
Patch (17.72 KB, patch)
2010-11-19 19:03 PST, Benjamin (Ben) Kalman
no flags
Patch (17.71 KB, patch)
2010-11-19 19:16 PST, Benjamin (Ben) Kalman
no flags
Patch for landing (17.52 KB, patch)
2010-11-22 10:26 PST, Tony Chang
commit-queue: commit-queue-
Patch (19.77 KB, patch)
2010-11-24 20:30 PST, Benjamin (Ben) Kalman
no flags
Benjamin (Ben) Kalman
Comment 1 2010-11-16 15:59:20 PST
Benjamin (Ben) Kalman
Comment 2 2010-11-18 17:16:52 PST
Tony Chang
Comment 3 2010-11-18 17:27:54 PST
Comment on attachment 74051 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74051&action=review You also want to add the new file to the various build files: GNUmakefile.am, WebCore.gypi, WebCore.pro, WebCore.vcproj/WebCore.vcproj, and WebCore.xcodeproj/project.pbxproj. I think it won't compile if you don't add it to the xcode project. > WebCore/editing/EditingBoundary.h:43 > +#endif /* EditingBoundary_h */ The comment should be //, not /* */
Benjamin (Ben) Kalman
Comment 4 2010-11-19 03:47:12 PST
Dumb question, but is there an easier way to add a file than manually changing 5 files..?
Darin Adler
Comment 5 2010-11-19 09:33:02 PST
(In reply to comment #4) > Dumb question, but is there an easier way to add a file than manually changing 5 files..? Not a dumb question at all. At the moment the answer is no, but we’re hoping someone will find a way to fix that.
Benjamin (Ben) Kalman
Comment 6 2010-11-19 19:03:23 PST
Benjamin (Ben) Kalman
Comment 7 2010-11-19 19:07:45 PST
> Not a dumb question at all. At the moment the answer is no, but we’re hoping someone will find a way to fix that. Yes, that would be nice.
WebKit Review Bot
Comment 8 2010-11-19 19:08:42 PST
Comment on attachment 74456 [details] Patch Rejecting patch 74456 from commit-queue. kalman@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Tony Chang
Comment 9 2010-11-19 19:11:14 PST
Comment on attachment 74456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74456&action=review > WebCore/WebCore.vcproj/WebCore.vcproj:46080 > > > + <File You're missing a </File>
Benjamin (Ben) Kalman
Comment 10 2010-11-19 19:16:49 PST
mitz
Comment 11 2010-11-22 09:30:19 PST
Comment on attachment 74457 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74457&action=review > WebCore/editing/EditingBoundary.h:2 > + * Copyright (c) 2010 Google Inc. All rights reserved. It is inappropriate to assign yourself copyright in code that you are merely moving.
Tony Chang
Comment 12 2010-11-22 09:53:53 PST
Comment on attachment 74457 [details] Patch Removing from cq based on mitz's comment.
Tony Chang
Comment 13 2010-11-22 10:26:01 PST
Created attachment 74570 [details] Patch for landing
WebKit Commit Bot
Comment 14 2010-11-22 20:44:36 PST
Comment on attachment 74570 [details] Patch for landing Rejecting patch 74570 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 74570]" exit_code: 2 Last 500 characters of output: ILED -- saving rejects to file WebCore/WebCore.xcodeproj/project.pbxproj.rej patching file WebCore/dom/Position.cpp patching file WebCore/dom/Position.h patching file WebCore/editing/DeleteSelectionCommand.cpp patching file WebCore/editing/EditingBoundary.h patching file WebCore/editing/visible_units.cpp patching file WebCore/editing/visible_units.h patching file WebCore/rendering/RenderObject.cpp Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/6363012
Benjamin (Ben) Kalman
Comment 15 2010-11-24 20:30:20 PST
Darin Adler
Comment 16 2010-11-27 18:28:36 PST
Comment on attachment 74827 [details] Patch Seems good to be in a separate file. Not sure it’s good that the file’s name is different from the enum type’s name, though. I would have made them the same.
WebKit Commit Bot
Comment 17 2010-11-27 18:54:59 PST
Comment on attachment 74827 [details] Patch Clearing flags on attachment: 74827 Committed r72777: <http://trac.webkit.org/changeset/72777>
WebKit Commit Bot
Comment 18 2010-11-27 18:55:05 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 19 2010-11-28 09:56:02 PST
http://trac.webkit.org/changeset/72777 might have broken GTK Linux 64-bit Debug
Note You need to log in before you can comment on or make changes to this bug.