Bug 49628 - Set the original URL for downloads
Summary: Set the original URL for downloads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-16 15:21 PST by Anders Carlsson
Modified: 2010-11-16 15:53 PST (History)
0 users

See Also:

Attachments
Patch (9.95 KB, patch)
2010-11-16 15:27 PST, Anders Carlsson 		sullivan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-11-16 15:21:11 PST 
Set the original URL for downloads
Comment 1 Anders Carlsson 2010-11-16 15:27:50 PST 
Created attachment 74047 [details]
Patch
Comment 2 John Sullivan 2010-11-16 15:46:53 PST 
Comment on attachment 74047 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74047&action=review

> WebKit2/WebProcess/Downloads/mac/DownloadMac.mm:68
> +}

It's non-obvious why we can get the originating URL from the back/forward list. The old code in WebFrameLoaderClient.mm included a few comments and a FIXME that make this a little clearer. I think it's worthwhile to reproduce those comments and FIXME here. (I see one of them is now in setOriginalURLForDownload, but the others aren't.)

It might also help to name this function originatingURLFromBackForwardList, since it's only used when there's no referrer.
Comment 3 Anders Carlsson 2010-11-16 15:53:43 PST 
Committed r72145: <http://trac.webkit.org/changeset/72145>