WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
49627
[Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=49627
Summary
[Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser
Andras Becsi
Reported
2010-11-16 14:57:27 PST
It is not possible to set custom user agent strings in MiniBrowser.
Attachments
proposed patch
(8.47 KB, patch)
2010-11-16 15:08 PST
,
Andras Becsi
no flags
Details
Formatted Diff
Diff
proposed patch v2
(10.21 KB, patch)
2010-11-17 08:43 PST
,
Andras Becsi
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Andras Becsi
Comment 1
2010-11-16 15:08:30 PST
Created
attachment 74045
[details]
proposed patch
Andreas Kling
Comment 2
2010-11-17 01:14:13 PST
Comment on
attachment 74045
[details]
proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=74045&action=review
> WebKitTools/MiniBrowser/qt/BrowserWindow.cpp:151 > + QDialog* dialog = new QDialog(this);
Put this on the stack instead, no need for the explicit delete later.
> WebKitTools/MiniBrowser/qt/MiniBrowser.qrc:3 > + <file>useragentlist.txt</file>
Could we share this file with QtTestBrowser somehow? Seems unnecessary to have two copies of it.
Andras Becsi
Comment 3
2010-11-17 08:43:20 PST
Created
attachment 74118
[details]
proposed patch v2 Addressed Andreas' suggestions.
Andreas Kling
Comment 4
2010-11-17 09:03:49 PST
Comment on
attachment 74118
[details]
proposed patch v2 View in context:
https://bugs.webkit.org/attachment.cgi?id=74118&action=review
LGTM, just one thing:
> WebKitTools/MiniBrowser/qt/BrowserWindow.cpp:141 > + ASSERT(!m_userAgentList.isEmpty());
Use Q_ASSERT instead and remove the WTF include + JavaScriptCore path in .pro
Andras Becsi
Comment 5
2010-11-17 10:40:39 PST
Committed
r72220
: <
http://trac.webkit.org/changeset/72220
>
Andras Becsi
Comment 6
2010-11-17 10:43:04 PST
Comment on
attachment 74118
[details]
proposed patch v2 Clearing flags.
Ryosuke Niwa
Comment 7
2010-11-17 10:59:46 PST
I think this broke qt release build.
Andras Becsi
Comment 8
2010-11-17 11:31:26 PST
(In reply to
comment #7
)
> I think this broke qt release build.
Build fixed with
r72223
and
r72224
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug