Bug 49625 - Focus ring in image maps does not take zooming into account
Summary: Focus ring in image maps does not take zooming into account
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-16 14:42 PST by Yael
Modified: 2010-11-19 10:39 PST (History)
2 users (show)

See Also:


Attachments
Patch. (47.21 KB, patch)
2010-11-18 06:57 PST, Yael
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2010-11-16 14:42:22 PST
http://trac.webkit.org/changeset/53857 added support for focus rings on imagemaps. The paths that are created for the focus ring do not take zooming into account.
Comment 1 Yael 2010-11-18 06:57:12 PST
Created attachment 74236 [details]
Patch.

Scale the path of the focus ring if pageZoomFactor is not 1.0.
Comment 2 Yael 2010-11-19 06:16:49 PST
Seems like  aproblem in the commit queue caused this patch to not build. This is the build error I got:

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 1
ERROR: Working directory has local commits, pass --force-clean to continue.

I am going to try again.
Comment 3 WebKit Commit Bot 2010-11-19 08:05:35 PST
Comment on attachment 74236 [details]
Patch.

Clearing flags on attachment: 74236

Committed r72402: <http://trac.webkit.org/changeset/72402>
Comment 4 WebKit Commit Bot 2010-11-19 08:05:40 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Commit Bot 2010-11-19 08:50:44 PST
The commit-queue encountered the following flaky tests while processing attachment 74236 [details]:

animations/dynamic-stylesheet-loading.html
accessibility/aria-activedescendant-crash.html

Please file bugs against the tests.  These tests were authored by adele@apple.com, cfleizach@apple.com, and cmarrin@apple.com.  The commit-queue is continuing to process your patch.