Bug 49623 - profileCallback and profileEndCallback should be guarded with ENABLE_JAVASCRIPT_DEBUGGER
Summary: profileCallback and profileEndCallback should be guarded with ENABLE_JAVASCR...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-16 14:13 PST by webkittenghui
Modified: 2010-11-17 09:56 PST (History)
5 users (show)

See Also:

Attachments
proposed patch (1.40 KB, patch)
2010-11-16 15:10 PST, webkittenghui 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description webkittenghui 2010-11-16 14:13:49 PST 
With changeset r71515, 2 functions profileCallback and profileEndCallback get added with guarded in the .idl file. 
But not the V8ConsoleCustom.cpp. 

This will cause android build break. 

I will have a patch shortly submit for review.
Comment 1 webkittenghui 2010-11-16 15:10:40 PST 
Created attachment 74046 [details]
proposed patch

Just a compiling error fix. Thanks for reviewing.
Comment 2 Jeremy Orlow 2010-11-17 06:27:10 PST 
Comment on attachment 74046 [details]
proposed patch

r=me
Comment 3 WebKit Commit Bot 2010-11-17 09:54:11 PST 
The commit-queue encountered the following flaky tests while processing attachment 74046 [details]:

inspector/styles-iframe.html

Please file bugs against the tests.  These tests were authored by loislo@chromium.org, pfeldman@chromium.org, and yurys@chromium.org.  The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2010-11-17 09:56:52 PST 
Comment on attachment 74046 [details]
proposed patch

Clearing flags on attachment: 74046

Committed r72216: <http://trac.webkit.org/changeset/72216>
Comment 5 WebKit Commit Bot 2010-11-17 09:56:58 PST 
All reviewed patches have been landed.  Closing bug.