It broke 3 tests on all bot: fast/dom/frame-loading-via-document-write.html fast/dom/HTMLHeadElement/head-check.html fast/frames/iframe-no-src-set-location.html http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28Tests%29/r72115%20%2820918%29/results.html
*** Bug 49620 has been marked as a duplicate of this bug. ***
The tests are still fail and the commit queue is block because of this bug. :( Any progression with the fix? Or should we rollout the patch?
Actually it is 5 tests: fast/dom/frame-loading-via-document-write.html fast/dom/HTMLHeadElement/head-check.html fast/dom/Window/open-existing-pop-up-blocking.html fast/frames/iframe-no-src-set-location.html fast/frames/location-change.html 3 failed immediately and 2 more in later runs (which was odd but they have the same error, so I believe they are the same).
It’s fine to roll out the patch for now. I should have run those tests before checking in. I’ll resubmit the patch with fixes for those tests. Sorry, I am in the middle of some other work and can’t take care of it myself.
(In reply to comment #4) > It’s fine to roll out the patch for now. I should have run those tests before checking in. I’ll resubmit the patch with fixes for those tests. > > Sorry, I am in the middle of some other work and can’t take care of it myself. I'm going to do the rollout. But please reopen the original bug, and comment it, because we don't have the power to do it.
Committed r72137.
(In reply to comment #5) > I'm going to do the rollout. But please reopen the original bug, > and comment it, because we don't have the power to do it. Sorry, I did it!
(In reply to comment #7) > Sorry, I did it! Not problem, you was the faster. :) Thx.