Bug 49611 - REGRESSION (r72115): 5 layout tests are broken
Summary: REGRESSION (r72115): 5 layout tests are broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Blocker
Assignee: Darin Adler
URL:
Keywords: LayoutTestFailure, Regression
: 49620 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-11-16 12:11 PST by Csaba Osztrogonác
Modified: 2010-11-16 14:53 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2010-11-16 12:11:42 PST
It broke 3 tests on all bot:
fast/dom/frame-loading-via-document-write.html
fast/dom/HTMLHeadElement/head-check.html
fast/frames/iframe-no-src-set-location.html

http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28Tests%29/r72115%20%2820918%29/results.html
Comment 1 Csaba Osztrogonác 2010-11-16 14:35:35 PST
*** Bug 49620 has been marked as a duplicate of this bug. ***
Comment 2 Csaba Osztrogonác 2010-11-16 14:38:14 PST
The tests are still fail and the commit queue is block because of this bug. :(
Any progression with the fix? Or should we rollout the patch?
Comment 3 David Levin 2010-11-16 14:40:16 PST
Actually it is 5 tests:
  fast/dom/frame-loading-via-document-write.html
  fast/dom/HTMLHeadElement/head-check.html
  fast/dom/Window/open-existing-pop-up-blocking.html
  fast/frames/iframe-no-src-set-location.html
  fast/frames/location-change.html

3 failed immediately and 2 more in later runs (which was odd but they have the same error, so I believe they are the same).
Comment 4 Darin Adler 2010-11-16 14:48:29 PST
It’s fine to roll out the patch for now. I should have run those tests before checking in. I’ll resubmit the patch with fixes for those tests.

Sorry, I am in the middle of some other work and can’t take care of it myself.
Comment 5 Csaba Osztrogonác 2010-11-16 14:50:58 PST
(In reply to comment #4)
> It’s fine to roll out the patch for now. I should have run those tests before checking in. I’ll resubmit the patch with fixes for those tests.
> 
> Sorry, I am in the middle of some other work and can’t take care of it myself.

I'm going to do the rollout.  But please reopen the original bug, 
and comment it, because we don't have the power to do it.
Comment 6 Darin Adler 2010-11-16 14:51:32 PST
Committed r72137.
Comment 7 Darin Adler 2010-11-16 14:51:50 PST
(In reply to comment #5)
> I'm going to do the rollout.  But please reopen the original bug, 
> and comment it, because we don't have the power to do it.

Sorry, I did it!
Comment 8 Csaba Osztrogonác 2010-11-16 14:53:11 PST
(In reply to comment #7)
> Sorry, I did it!
Not problem, you was the faster. :) Thx.