Bug 49575 - webkit-patch blows up when the first line of ChangeLog is a blank line
Summary: webkit-patch blows up when the first line of ChangeLog is a blank line
Status: RESOLVED DUPLICATE of bug 45988
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-15 17:51 PST by Ryosuke Niwa
Modified: 2011-06-29 13:23 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2010-11-15 17:51:36 PST
When there is a blank line at the beginning of ChangeLog, webkit-patch crashes with the following stack trace:

Total errors found: 0 in 8 files
Traceback (most recent call last):
  File "WebKitTools/Scripts/webkit-patch", line 70, in <module>
    main()
  File "WebKitTools/Scripts/webkit-patch", line 65, in main
    WebKitPatch(__file__).main()
  File "/co/webkit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main
  File "/co/webkit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute
  File "/co/webkit/WebKitTools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 43, in execute
  File "/co/webkit/WebKitTools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors
  File "/co/webkit/WebKitTools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
  File "/co/webkit/WebKitTools/Scripts/webkitpy/tool/steps/preparechangelog.py", line 61, in run
  File "/co/webkit/WebKitTools/Scripts/webkitpy/tool/steps/preparechangelog.py", line 54, in _ensure_bug_url
AttributeError: 'NoneType' object has no attribute 'bug_id'

It should print out more user-friendly message or remove leading blank lines.
Comment 1 Eric Seidel (no email) 2011-06-29 13:23:28 PDT

*** This bug has been marked as a duplicate of bug 45988 ***