Bug 49567 - nrwt multiprocessing - remove port-specific child process restrictions
Summary: nrwt multiprocessing - remove port-specific child process restrictions
Status: RESOLVED DUPLICATE of bug 50381
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks: 49566
  Show dependency treegraph
 
Reported: 2010-11-15 15:21 PST by Dirk Pranke
Modified: 2010-12-02 02:54 PST (History)
5 users (show)

See Also:


Attachments
Patch (2.65 KB, patch)
2010-11-15 15:27 PST, Dirk Pranke
ojan: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-11-15 15:21:39 PST
need to remove the platform-specific restrictions on the default # of child processes when we fix the threading/multiprocessing issues.
Comment 1 Dirk Pranke 2010-11-15 15:27:10 PST
Created attachment 73936 [details]
Patch
Comment 2 Dirk Pranke 2010-11-15 15:28:55 PST
Note that this should actually be the *last* of the MP (multiprocess) patches to land, after all the code is working and tested.

The GPU tests (in chromium_gpu.py) will still default to 1, since there's GPU-related stability with parallel testing.
Comment 3 Ojan Vafai 2010-11-16 06:25:12 PST
Comment on attachment 73936 [details]
Patch

Marking r- for now just because it's blocked on other patches. Maybe r? this patch once it's actually possible to commit it? The patch looks fine, although I expect the assumption is that another patch removes the default_child_processes call somewhere.
Comment 4 Dirk Pranke 2010-11-16 11:39:01 PST
(In reply to comment #0)
> need to remove the platform-specific restrictions on the default # of child processes when we fix the threading/multiprocessing issues.

r- for now is fine.

We still need the call, though, which will fall through to the base class implementation, which gives us the # of CPUs.
Comment 5 Dirk Pranke 2010-12-02 02:54:48 PST
closing as wontfix - 50381 is now the way to do this.

*** This bug has been marked as a duplicate of bug 50381 ***