Bug 49559 - DOMWindow.getComputedStyle pseudo element argument lacks ConvertUndefinedOrNullToNullString
Summary: DOMWindow.getComputedStyle pseudo element argument lacks ConvertUndefinedOrNu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Trivial
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-15 13:08 PST by Alexey Proskuryakov
Modified: 2010-11-15 13:52 PST (History)
2 users (show)

See Also:


Attachments
proposed patch (1.25 KB, patch)
2010-11-15 13:11 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2010-11-15 13:08:42 PST
Per MDC, it "must be null (or not specified) for regular elements."

As far as I can tell, this makes no difference in practice, because "null" and "undefined" are not pseudo element names, and don't even start with ":". But it seems cleaner not to pass them to DOM code.
Comment 1 Alexey Proskuryakov 2010-11-15 13:11:01 PST
Created attachment 73924 [details]
proposed patch
Comment 2 Darin Adler 2010-11-15 13:13:52 PST
Comment on attachment 73924 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73924&action=review

> WebCore/ChangeLog:8
> +        No observable change in behavior, so no tests.

Why do this if there is no observable change in behavior?
Comment 3 Darin Adler 2010-11-15 13:14:44 PST
Comment on attachment 73924 [details]
proposed patch

Maybe we can change the default some day. I can’t remember how this relates to the similar properties in WebIDL.
Comment 4 Alexey Proskuryakov 2010-11-15 13:20:55 PST
Comment on attachment 73924 [details]
proposed patch

Well, basically it's just that I was surprised and confused to see "null" and "undefined" passed to DOM code when debugging.
Comment 5 WebKit Commit Bot 2010-11-15 13:52:33 PST
Comment on attachment 73924 [details]
proposed patch

Clearing flags on attachment: 73924

Committed r72036: <http://trac.webkit.org/changeset/72036>
Comment 6 WebKit Commit Bot 2010-11-15 13:52:38 PST
All reviewed patches have been landed.  Closing bug.