Bug 49542 - [Qt][WK2] Avoid polling in WebKitTestRunner
Summary: [Qt][WK2] Avoid polling in WebKitTestRunner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Andras Becsi
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-11-15 07:25 PST by Andras Becsi
Modified: 2010-11-15 13:37 PST (History)
3 users (show)

See Also:

Attachments
proposed patch (7.10 KB, patch)
2010-11-15 07:48 PST, Andras Becsi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Becsi 2010-11-15 07:25:36 PST 
In the Qt implementation of TestController we are currently using a polling mechanism to check whether the condition is met.
By refactoring RunUntilConditionLoop to avoid polling we can make the WK2 testing session about 10-15% faster and decrease random flackyness resulting from timing skew.
Comment 1 Andras Becsi 2010-11-15 07:48:57 PST 
Created attachment 73894 [details]
proposed patch
Comment 2 Andreas Kling 2010-11-15 13:19:06 PST 
Comment on attachment 73894 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73894&action=review

Much better, r=me!

> WebKitTools/ChangeLog:8
> +        Make the WK2 testing session about 10-15% faster and decrease random flackyness

s/flackyness/flakiness/
Comment 3 Andras Becsi 2010-11-15 13:36:54 PST 
(In reply to comment #2)
> s/flackyness/flakiness/

Fixed and committed in r72031: <http://trac.webkit.org/changeset/72031>
Closing bug.
Comment 4 Andras Becsi 2010-11-15 13:37:27 PST 
Comment on attachment 73894 [details]
proposed patch

Clearing flags.