Bug 49527 – Web Inspector: Do not hide default Ctrl+A behavior on non-Mac

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Otherwise select all in console does not work.

[Pavel Feldman]

Created attachment 73878 [details]
[PATCH] Proposed change.

[Yury Semikhatsky]

Comment on attachment 73878 [details]
[PATCH] Proposed change.

View in context: https://bugs.webkit.org/attachment.cgi?id=73878&action=review

I personally find these shortcuts quite useful and think that it would be nice to provide a shortcut for go-to-{start, end} on other platforms.

> WebCore/inspector/front-end/TextPrompt.js:-111
> -            case "U+0045": // Ctrl+E = Move caret to the end of prompt on non-Mac.

does this conflict with some other action as well?

[Pavel Feldman]

(In reply to comment #2)
> (From update of attachment 73878 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=73878&action=review
> 
> I personally find these shortcuts quite useful and think that it would be nice to provide a shortcut for go-to-{start, end} on other platforms.
> 

Home and End works.
> > WebCore/inspector/front-end/TextPrompt.js:-111
> > -            case "U+0045": // Ctrl+E = Move caret to the end of prompt on non-Mac.
> 
> does this conflict with some other action as well?

No, just for consistency.

[WebKit Commit Bot]

Comment on attachment 73878 [details]
[PATCH] Proposed change.

Clearing flags on attachment: 73878

Committed r72002: <http://trac.webkit.org/changeset/72002>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.