Bug 49527 - Web Inspector: Do not hide default Ctrl+A behavior on non-Mac
Summary: Web Inspector: Do not hide default Ctrl+A behavior on non-Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-15 01:55 PST by Pavel Feldman
Modified: 2010-11-15 04:10 PST (History)
11 users (show)

See Also:


Attachments
[PATCH] Proposed change. (2.36 KB, patch)
2010-11-15 02:00 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-11-15 01:55:26 PST
Otherwise select all in console does not work.
Comment 1 Pavel Feldman 2010-11-15 02:00:43 PST
Created attachment 73878 [details]
[PATCH] Proposed change.
Comment 2 Yury Semikhatsky 2010-11-15 02:39:00 PST
Comment on attachment 73878 [details]
[PATCH] Proposed change.

View in context: https://bugs.webkit.org/attachment.cgi?id=73878&action=review

I personally find these shortcuts quite useful and think that it would be nice to provide a shortcut for go-to-{start, end} on other platforms.

> WebCore/inspector/front-end/TextPrompt.js:-111
> -            case "U+0045": // Ctrl+E = Move caret to the end of prompt on non-Mac.

does this conflict with some other action as well?
Comment 3 Pavel Feldman 2010-11-15 02:43:20 PST
(In reply to comment #2)
> (From update of attachment 73878 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=73878&action=review
> 
> I personally find these shortcuts quite useful and think that it would be nice to provide a shortcut for go-to-{start, end} on other platforms.
> 

Home and End works.
> > WebCore/inspector/front-end/TextPrompt.js:-111
> > -            case "U+0045": // Ctrl+E = Move caret to the end of prompt on non-Mac.
> 
> does this conflict with some other action as well?

No, just for consistency.
Comment 4 WebKit Commit Bot 2010-11-15 04:10:06 PST
Comment on attachment 73878 [details]
[PATCH] Proposed change.

Clearing flags on attachment: 73878

Committed r72002: <http://trac.webkit.org/changeset/72002>
Comment 5 WebKit Commit Bot 2010-11-15 04:10:12 PST
All reviewed patches have been landed.  Closing bug.