After http://trac.webkit.org/changeset/69766 the focus ring on links is no longer visible in Qt. The reason is that Qt always returned true in RenderTheme::supportsFocusRing(), but until r69766, we did not check that for links. Qt draws its own focus ring for controls that it draws, but not for links. A patch is coming soon.
Created attachment 73858 [details] Patch RenderTheme::supportsFocusRing should check the style appearance before it decides if to return true or false.
Comment on attachment 73858 [details] Patch It would be nice if Ossy could check it on the bots, so it does not fail due to font differences.
Antonio, thanks for the review. Ossy, could you please check that? thanks,
(In reply to comment #3) > Antonio, thanks for the review. > Ossy, could you please check that? > thanks, Done, it works for me. Next time you can check it yourself with our Q-BAT: http://webkit.sed.hu/blog/20101028/qtwebkit-builder-and-tester-virtual-machine
Comment on attachment 73858 [details] Patch cq+
(In reply to comment #4) > (In reply to comment #3) > > Antonio, thanks for the review. > > Ossy, could you please check that? > > thanks, > > Done, it works for me. Next time you can check it yourself with our Q-BAT: > http://webkit.sed.hu/blog/20101028/qtwebkit-builder-and-tester-virtual-machine Thanks, Ossy.
Comment on attachment 73858 [details] Patch Clearing flags on attachment: 73858 Committed r72004: <http://trac.webkit.org/changeset/72004>
All reviewed patches have been landed. Closing bug.