Bug 49512 – check-webkit-style function detection and the line count style checks should be separate.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[David Levin]

As I add more checks related to function state, it seemed to made sense to separate the checks from the function detection.

It seemed odd that the function was named check_for_function_lengths but it was also setting up the FunctionState that I wanted to use elsewhere.

[David Levin]

Created attachment 73853 [details]
Patch

[David Levin]

Created attachment 73854 [details]
The same patch but ignoring all space changes. (git diff -w)

I'm adding this patch because the real patch makes the changes look much bigger than they are.

Due to some code rearrangement, I was able to change to a "fail fast" pattern in several places and unindent code and this looks like big changes.

[Shinichiro Hamaji]

Comment on attachment 73853 [details]
Patch

Looks good.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 73853 [details]:

fast/workers/storage/use-same-database-in-page-and-workers.html

Please file bugs against the tests.  These tests were authored by [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 73853 [details]
Patch

Clearing flags on attachment: 73853

Committed r71986: <http://trac.webkit.org/changeset/71986>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.