Bug 49512 - check-webkit-style function detection and the line count style checks should be separate.
Summary: check-webkit-style function detection and the line count style checks should ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-14 10:55 PST by David Levin
Modified: 2010-11-14 12:00 PST (History)
3 users (show)

See Also:


Attachments
Patch (11.71 KB, patch)
2010-11-14 10:59 PST, David Levin
no flags Details | Formatted Diff | Diff
The same patch but ignoring all space changes. (git diff -w) (9.38 KB, patch)
2010-11-14 11:06 PST, David Levin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2010-11-14 10:55:46 PST
As I add more checks related to function state, it seemed to made sense to separate the checks from the function detection.

It seemed odd that the function was named check_for_function_lengths but it was also setting up the FunctionState that I wanted to use elsewhere.
Comment 1 David Levin 2010-11-14 10:59:16 PST
Created attachment 73853 [details]
Patch
Comment 2 David Levin 2010-11-14 11:06:59 PST
Created attachment 73854 [details]
The same patch but ignoring all space changes. (git diff -w)

I'm adding this patch because the real patch makes the changes look much bigger than they are.

Due to some code rearrangement, I was able to change to a "fail fast" pattern in several places and unindent code and this looks like big changes.
Comment 3 Shinichiro Hamaji 2010-11-14 11:36:23 PST
Comment on attachment 73853 [details]
Patch

Looks good.
Comment 4 WebKit Commit Bot 2010-11-14 11:58:54 PST
The commit-queue encountered the following flaky tests while processing attachment 73853 [details]:

fast/workers/storage/use-same-database-in-page-and-workers.html

Please file bugs against the tests.  These tests were authored by dumi@chromium.org.  The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2010-11-14 11:59:54 PST
Comment on attachment 73853 [details]
Patch

Clearing flags on attachment: 73853

Committed r71986: <http://trac.webkit.org/changeset/71986>
Comment 6 WebKit Commit Bot 2010-11-14 12:00:00 PST
All reviewed patches have been landed.  Closing bug.