As I add more checks related to function state, it seemed to made sense to separate the checks from the function detection. It seemed odd that the function was named check_for_function_lengths but it was also setting up the FunctionState that I wanted to use elsewhere.
Created attachment 73853 [details] Patch
Created attachment 73854 [details] The same patch but ignoring all space changes. (git diff -w) I'm adding this patch because the real patch makes the changes look much bigger than they are. Due to some code rearrangement, I was able to change to a "fail fast" pattern in several places and unindent code and this looks like big changes.
Comment on attachment 73853 [details] Patch Looks good.
The commit-queue encountered the following flaky tests while processing attachment 73853 [details]: fast/workers/storage/use-same-database-in-page-and-workers.html Please file bugs against the tests. These tests were authored by dumi@chromium.org. The commit-queue is continuing to process your patch.
Comment on attachment 73853 [details] Patch Clearing flags on attachment: 73853 Committed r71986: <http://trac.webkit.org/changeset/71986>
All reviewed patches have been landed. Closing bug.