broken-ideographic-font.html fails in release builds
Created attachment 73832 [details] Patch
Comment on attachment 73832 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73832&action=review > WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:44 > - unsigned key = typesettingFeatures + 1; > + unsigned key = 1 + ((typesettingFeatures | (orientation() == Vertical ? 4 : 0)) << 1); I don’t like this part of the change. orientation() is always the same for a SimpleFontData instance, so there’s never a need to include it in the key.
Created attachment 73835 [details] Clean up small caps even more and remove the change that Dan noticed was irrelevant.
Comment on attachment 73835 [details] Clean up small caps even more and remove the change that Dan noticed was irrelevant. View in context: https://bugs.webkit.org/attachment.cgi?id=73835&action=review > WebCore/ChangeLog:16 > + I made sure that the hash for m_CFStringAttributes includes orientation. I don't think this is a bug > + in practice, but this way the code is future-proofed. No longer part of the change.
Fixed in r71975.