Bug 49493 – Web Inspector: [refactoring] support Views in TabbedPane and streamline tab selection in resource view

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Andrey Kosyakov]

TabbedPane currently expects child "windows" to be tabs. The proposed patch adds support for Views that are selected via View.visible. This allows moving custom logic associated with tab being selected into overridden View.Show(), which, in turn, allows to streamline tab selection logic in ResourceView.

[Andrey Kosyakov]

Created attachment 73823 [details]
patch

[Andrey Kosyakov]

(In reply to comment #0)
> TabbedPane currently expects child "windows" to be tabs. 
s/tabs/elements/

[Pavel Feldman]

Comment on attachment 73823 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73823&action=review

> WebCore/ChangeLog:10
> +        No new tests. (OOPS!)

Remove this line.

> WebCore/inspector/front-end/ResourceView.js:163
> +                tab = this.tabbedPane.hasTab(preferredTab) ? preferredTab : "headers";

We used to go to "content" by default, now we should "headers". However, now that we have split resources and network, I think this is right!

> WebCore/inspector/front-end/TabbedPane.js:72
> +    _setSelection: function(tabObject, isSelected)

split this into _showTab and _hideTab?

[Andrey Kosyakov]

Created attachment 73827 [details]
patch to land

All review comments addressed.

[Andrey Kosyakov]

Manually committed r71967: http://trac.webkit.org/changeset/71967