Bug 49493 - Web Inspector: [refactoring] support Views in TabbedPane and streamline tab selection in resource view
Summary: Web Inspector: [refactoring] support Views in TabbedPane and streamline tab s...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
Depends on:
Reported: 2010-11-13 07:04 PST by Andrey Kosyakov
Modified: 2010-11-13 08:42 PST (History)
10 users (show)

See Also:

patch (10.50 KB, patch)
2010-11-13 07:14 PST, Andrey Kosyakov
pfeldman: review+
pfeldman: commit-queue-
Details | Formatted Diff | Diff
patch to land (10.57 KB, patch)
2010-11-13 08:20 PST, Andrey Kosyakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2010-11-13 07:04:11 PST
TabbedPane currently expects child "windows" to be tabs. The proposed patch adds support for Views that are selected via View.visible. This allows moving custom logic associated with tab being selected into overridden View.Show(), which, in turn, allows to streamline tab selection logic in ResourceView.
Comment 1 Andrey Kosyakov 2010-11-13 07:14:08 PST
Created attachment 73823 [details]
Comment 2 Andrey Kosyakov 2010-11-13 07:19:13 PST
(In reply to comment #0)
> TabbedPane currently expects child "windows" to be tabs. 
Comment 3 Pavel Feldman 2010-11-13 07:47:24 PST
Comment on attachment 73823 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=73823&action=review

> WebCore/ChangeLog:10
> +        No new tests. (OOPS!)

Remove this line.

> WebCore/inspector/front-end/ResourceView.js:163
> +                tab = this.tabbedPane.hasTab(preferredTab) ? preferredTab : "headers";

We used to go to "content" by default, now we should "headers". However, now that we have split resources and network, I think this is right!

> WebCore/inspector/front-end/TabbedPane.js:72
> +    _setSelection: function(tabObject, isSelected)

split this into _showTab and _hideTab?
Comment 4 Andrey Kosyakov 2010-11-13 08:20:19 PST
Created attachment 73827 [details]
patch to land

All review comments addressed.
Comment 5 Andrey Kosyakov 2010-11-13 08:42:04 PST
Manually committed r71967: http://trac.webkit.org/changeset/71967