TabbedPane currently expects child "windows" to be tabs. The proposed patch adds support for Views that are selected via View.visible. This allows moving custom logic associated with tab being selected into overridden View.Show(), which, in turn, allows to streamline tab selection logic in ResourceView.
Created attachment 73823 [details] patch
(In reply to comment #0) > TabbedPane currently expects child "windows" to be tabs. s/tabs/elements/
Comment on attachment 73823 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=73823&action=review > WebCore/ChangeLog:10 > + No new tests. (OOPS!) Remove this line. > WebCore/inspector/front-end/ResourceView.js:163 > + tab = this.tabbedPane.hasTab(preferredTab) ? preferredTab : "headers"; We used to go to "content" by default, now we should "headers". However, now that we have split resources and network, I think this is right! > WebCore/inspector/front-end/TabbedPane.js:72 > + _setSelection: function(tabObject, isSelected) split this into _showTab and _hideTab?
Created attachment 73827 [details] patch to land All review comments addressed.
Manually committed r71967: http://trac.webkit.org/changeset/71967