Bug 49492 - Web Inspector: Migrate frontend to the new CSS editing/retrieval API
Summary: Web Inspector: Migrate frontend to the new CSS editing/retrieval API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-13 05:09 PST by Alexander Pavlov (apavlov)
Modified: 2010-11-16 09:04 PST (History)
14 users (show)

See Also:


Attachments
[PATCH] Suggested solution (59.77 KB, patch)
2010-11-15 08:54 PST, Alexander Pavlov (apavlov)
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2010-11-13 05:09:08 PST
Now that InspectorCSSAgent is live, the WebInspector frontend should be migrated to the new set of CSS-related InspectorBackend API methods.
Comment 1 Alexander Pavlov (apavlov) 2010-11-15 08:54:35 PST
Created attachment 73903 [details]
[PATCH] Suggested solution
Comment 2 Pavel Feldman 2010-11-15 09:04:01 PST
Comment on attachment 73903 [details]
[PATCH] Suggested solution

View in context: https://bugs.webkit.org/attachment.cgi?id=73903&action=review

> WebCore/inspector/front-end/CSSStyleModel.js:508
> +    get text()

Nit: getText: function()
Comment 3 Alexander Pavlov (apavlov) 2010-11-16 07:38:07 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       LayoutTests/ChangeLog
        M       LayoutTests/inspector/audits-panel-functional-expected.txt
        M       LayoutTests/inspector/elements-panel-styles-expected.txt
        A       LayoutTests/inspector/resources/styles-new-API.css
        A       LayoutTests/inspector/styles-new-API-expected.txt
        A       LayoutTests/inspector/styles-new-API.html
        M       WebCore/ChangeLog
        M       WebCore/inspector/InspectorStyleSheet.cpp
        M       WebCore/inspector/front-end/AuditRules.js
        M       WebCore/inspector/front-end/CSSStyleModel.js
        M       WebCore/inspector/front-end/Settings.js
        M       WebCore/inspector/front-end/StylesSidebarPane.js
        M       WebCore/inspector/front-end/inspector.css
Committed r72096
Comment 4 WebKit Review Bot 2010-11-16 09:04:08 PST
http://trac.webkit.org/changeset/72096 might have broken GTK Linux 32-bit Debug