Bug 49490 – [Qt] Path stroke lacks blur shadow support

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Helder Correia]

ctx.blurShadow is not working for paths in the Qt port, it results a solid shadow.

[Helder Correia]

Created attachment 73811 [details]
Patch

[Helder Correia]

Created attachment 73843 [details]
Patch

[Helder Correia]

Created attachment 74441 [details]
Patch

[Helder Correia]

Created attachment 74450 [details]
Test for stroke gradient and fill, not path

[Helder Correia]

(In reply to comment #4)
> Created an attachment (id=74450) [details]
> Test for stroke gradient and fill, not path

What I meant was "stroke gradient and pattern, not fill gradient and pattern".

[Andreas Kling]

Comment on attachment 74450 [details]
Test for stroke gradient and fill, not path

View in context: https://bugs.webkit.org/attachment.cgi?id=74450&action=review

Patch looks good, except one thing:

> LayoutTests/ChangeLog:6
> +        [Qt] Path fill lacks blur shadow support
> +        https://bugs.webkit.org/show_bug.cgi?id=49491

This refers to the wrong bug.

[Helder Correia]

Created attachment 74466 [details]
Fix bug ID in changelog

[Andreas Kling]

Comment on attachment 74466 [details]
Fix bug ID in changelog

r=me

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 74466 [details]:

fast/canvas/canvas-strokePath-shadow.html
compositing/iframes/overlapped-nested-iframes.html

Please file bugs against the tests.  These tests were authored by [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 74466 [details]
Fix bug ID in changelog

Rejecting patch 74466 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2
Last 500 characters of output:
.......................
fast/body-propagation/overflow ...................
fast/borders .............................................................
fast/box-shadow .....
fast/box-sizing ....
fast/canvas .........................................................
fast/canvas/canvas-strokePath-shadow.html -> failed

Exiting early after 1 failures. 6085 tests run.
139.28s total testing time

6084 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
3 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/6260053

[Helder Correia]

Created attachment 74493 [details]
Remove duplicate file content from the test

[Andreas Kling]

Comment on attachment 74493 [details]
Remove duplicate file content from the test

D'oh! :)

[WebKit Commit Bot]

Comment on attachment 74493 [details]
Remove duplicate file content from the test

Clearing flags on attachment: 74493

Committed r72490: <http://trac.webkit.org/changeset/72490>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.