Bug 49485 - run platform/chromium/plugins/refcount-leaks.html on all platforms
Summary: run platform/chromium/plugins/refcount-leaks.html on all platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-12 17:30 PST by Tony Chang
Modified: 2010-11-18 11:22 PST (History)
4 users (show)

See Also:

Attachments
Patch (14.02 KB, patch)
2010-11-12 17:35 PST, Tony Chang 		no flags Details | Formatted Diff | Diff
Patch (16.61 KB, patch)
2010-11-16 10:33 PST, Tony Chang 		abarth: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-11-12 17:30:59 PST 
run platform/chromium/plugins/refcount-leaks.html on all platforms
Comment 1 Tony Chang 2010-11-12 17:35:41 PST 
Created attachment 73799 [details]
Patch
Comment 2 Tony Chang 2010-11-12 17:48:23 PST 
Comment on attachment 73799 [details]
Patch

This is failing on mac.  Let me debug . . .
Comment 3 Tony Chang 2010-11-16 10:33:24 PST 
Created attachment 74008 [details]
Patch
Comment 4 Tony Chang 2010-11-16 12:45:02 PST 
This is the last bit of functionality I need to add to the test plugin to pass all the Chromium plugin tests.
Comment 5 Tony Chang 2010-11-17 12:33:48 PST 
Adam, do you have time to review this?  It's the last plugin change before being able to switch the Chromium test plugin to the upstream one.
Comment 6 Adam Barth 2010-11-17 13:59:40 PST 
Comment on attachment 74008 [details]
Patch

For you Tony, I would review this patch five times.
Comment 7 Tony Chang 2010-11-17 14:00:39 PST 
(In reply to comment #6)
> (From update of attachment 74008 [details])
> For you Tony, I would review this patch five times.

:)  Thanks, Adam.
Comment 8 Tony Chang 2010-11-18 09:54:39 PST 
Committed r72302: <http://trac.webkit.org/changeset/72302>
Comment 9 WebKit Review Bot 2010-11-18 10:49:11 PST 
http://trac.webkit.org/changeset/72302 might have broken Qt Linux Release
Comment 10 Tony Chang 2010-11-18 11:22:30 PST 
(In reply to comment #9)
> http://trac.webkit.org/changeset/72302 might have broken Qt Linux Release

Filed https://bugs.webkit.org/show_bug.cgi?id=49749