Bug 49471 – webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Mihai Parparita]

webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch

[Mihai Parparita]

Created attachment 73771 [details]
Patch

[Adam Barth]

Comment on attachment 73771 [details]
Patch

Nice.  I figured cowboys didn't care what rev they landed as.  :)

[Mihai Parparita]

(In reply to comment #2)
> (From update of attachment 73771 [details])
> Nice.  I figured cowboys didn't care what rev they landed as.  :)

I've been keeping a log of all that I've had to do as WebKit gardener this week, having revision links is useful :)

[WebKit Commit Bot]

Comment on attachment 73771 [details]
Patch

Rejecting patch 73771 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 73771]" exit_code: 1
Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=73771&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=49471&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Updating working directory
Processing patch 73771 from bug 49471.
ERROR: /Projects/CommitQueue/WebKitTools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/5719027

[Mihai Parparita]

Committed r71954: <http://trac.webkit.org/changeset/71954>

[Mihai Parparita]

(In reply to comment #4)
> Rejecting patch 73771 from commit-queue.

I mistakenly took out the "Reviewed by NOBODY (OOPS!)." so the cq couldn't fix up the ChangeLog. I did it locally, and landed the patch.

Though I now see that webkit-patch land outputs the revision twice, the second time presumably because it's outputting the comment that it's adding to the bug. Will fix.

$ webkit-patch land
Parsing ChangeLog: /Users/mihaip/Developer/source/chromium1/src/third_party/WebKit/WebKitTools/ChangeLog
Fetching: https://bugs.webkit.org/show_bug.cgi?id=49471&ctype=xml
Guessing "Adam Barth" as reviewer from attachment 73771 [details] on bug 49471.
Parsing ChangeLog: /Users/mihaip/Developer/source/chromium1/src/third_party/WebKit/WebKitTools/ChangeLog
Committed r71954: <http://trac.webkit.org/changeset/71954>
Updating bug 49471
Logging in as [e-mail]...
Closing bug 49471 as fixed
Committed r71954: <http://trac.webkit.org/changeset/71954>

[Adam Barth]

> Though I now see that webkit-patch land outputs the revision twice, the second time presumably because it's outputting the comment that it's adding to the bug. Will fix.

Yep.  :)

We have a couple other "duplicate output" bugs.

[Adam Barth]

I should also say that your patch is correct in that it outputs the revision from the right piece of code.  The other place we're output it is wrong.