Bug 49471 - webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch
Summary: webkit-patch land-cowboy (and other commands) should display the committed SV...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mihai Parparita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-12 13:39 PST by Mihai Parparita
Modified: 2010-11-12 16:00 PST (History)
3 users (show)

See Also:


Attachments
Patch (6.55 KB, patch)
2010-11-12 13:44 PST, Mihai Parparita
abarth: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Parparita 2010-11-12 13:39:49 PST
webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch
Comment 1 Mihai Parparita 2010-11-12 13:44:47 PST
Created attachment 73771 [details]
Patch
Comment 2 Adam Barth 2010-11-12 15:01:16 PST
Comment on attachment 73771 [details]
Patch

Nice.  I figured cowboys didn't care what rev they landed as.  :)
Comment 3 Mihai Parparita 2010-11-12 15:09:20 PST
(In reply to comment #2)
> (From update of attachment 73771 [details])
> Nice.  I figured cowboys didn't care what rev they landed as.  :)

I've been keeping a log of all that I've had to do as WebKit gardener this week, having revision links is useful :)
Comment 4 WebKit Commit Bot 2010-11-12 15:20:05 PST
Comment on attachment 73771 [details]
Patch

Rejecting patch 73771 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 73771]" exit_code: 1
Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=73771&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=49471&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Updating working directory
Processing patch 73771 from bug 49471.
ERROR: /Projects/CommitQueue/WebKitTools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/5719027
Comment 5 Mihai Parparita 2010-11-12 15:54:33 PST
Committed r71954: <http://trac.webkit.org/changeset/71954>
Comment 6 Mihai Parparita 2010-11-12 15:57:01 PST
(In reply to comment #4)
> Rejecting patch 73771 from commit-queue.

I mistakenly took out the "Reviewed by NOBODY (OOPS!)." so the cq couldn't fix up the ChangeLog. I did it locally, and landed the patch.

Though I now see that webkit-patch land outputs the revision twice, the second time presumably because it's outputting the comment that it's adding to the bug. Will fix.

$ webkit-patch land
Parsing ChangeLog: /Users/mihaip/Developer/source/chromium1/src/third_party/WebKit/WebKitTools/ChangeLog
Fetching: https://bugs.webkit.org/show_bug.cgi?id=49471&ctype=xml
Guessing "Adam Barth" as reviewer from attachment 73771 [details] on bug 49471.
Parsing ChangeLog: /Users/mihaip/Developer/source/chromium1/src/third_party/WebKit/WebKitTools/ChangeLog
Committed r71954: <http://trac.webkit.org/changeset/71954>
Updating bug 49471
Logging in as mihaip@chromium.org...
Closing bug 49471 as fixed
Committed r71954: <http://trac.webkit.org/changeset/71954>
Comment 7 Adam Barth 2010-11-12 16:00:14 PST
> Though I now see that webkit-patch land outputs the revision twice, the second time presumably because it's outputting the comment that it's adding to the bug. Will fix.

Yep.  :)

We have a couple other "duplicate output" bugs.
Comment 8 Adam Barth 2010-11-12 16:00:55 PST
I should also say that your patch is correct in that it outputs the revision from the right piece of code.  The other place we're output it is wrong.