When trying to merge the webkit r 71558 to android, we found that the some generated .h file is containing declaration wrongly. When the SVGStaticListPropertyTearOff is expected, SVGListPropertyTearOff is generated. This is caused by the CodeGeneratorV8.pm.
BTW, I already have the fix ready , just need to run more tests before submitting the change.
Created attachment 73783 [details] proposed patch
Comment on attachment 73783 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=73783&action=review > WebCore/ChangeLog:5 > + Need a short description and bug URL (OOPS!) Oops indeed, this should be replaced by something like: [V8] Code generation script error in generating the SVGStaticListPropertyTearOff https://bugs.webkit.org/show_bug.cgi?id=49463 > WebCore/ChangeLog:7 > + No new tests. (OOPS!) If you're not adding any tests, this should be replaced by something like: No new tests, this is already covered by X, Y and Z. OR No new tests, this is untestable for reason X. Of course, if it's a compile fix, just remove this line. :-)
Created attachment 73792 [details] proposed patch, same as previous one, but better formatted patch file This is essentially the same change as the previous patch. I just update the myNewPmPatch.txt to add more info like bug info and change description. Thanks!
Comment on attachment 73792 [details] proposed patch, same as previous one, but better formatted patch file r=me
Comment on attachment 73792 [details] proposed patch, same as previous one, but better formatted patch file Rejecting patch 73792 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 73792]" exit_code: 2 Last 500 characters of output: ocessing 1 patch from 1 bug. Processing patch 73792 from bug 49463. Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 2 Parsed 2 diffs from patch file(s). patching file WebCore/ChangeLog patch: **** unexpected end of file in patch patching file WebCore/bindings/scripts/CodeGeneratorV8.pm Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 2 Full output: http://queues.webkit.org/results/5849005
Any hint on what could go wrong with the patch file? Thanks!
(In reply to comment #7) > Any hint on what could go wrong with the patch file? Thanks! Did you manually edit it the patch after creating it? I would have expected "@@ -1,3 +1,86 @@" to be more like "@@ -1,3 +1,15 @@"
I only touch the changelog and the lines starting with a "+". I think that will be pretty safe to change. Maybe I have to try to recreate the patch file again then.
Committed r71984: <http://trac.webkit.org/changeset/71984>