Bug 49462 – Code dependency with INSPECTOR cause build break for android

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: WebCore Misc.

When trying to build code from webkit version 71558 for android, some of the common code began to use OwnPtr<ScriptCallBack>. 
This leads to the dependency on InspectorObject and InspectorArray which is INSPECTOR specific code.

BTW, I already have the fix ready , just need to run more tests before submitting the change.

Created attachment 73785 [details]
proposed patch

[Andreas Kling]

Comment on attachment 73785 [details]
proposed patch

Needs a ChangeLog entry.
See http://webkit.org/coding/contributing.html for more information.

Created attachment 73790 [details]
proposed patch, same as previous one, but better formatted patch file

The change is essentially the same as previous attached patch, but the myInspectorPatch.txt is added with bug info and change description etc.

[Andreas Kling]

Comment on attachment 73790 [details]
proposed patch, same as previous one, but better formatted patch file

LGTM.

[WebKit Commit Bot]

Comment on attachment 73790 [details]
proposed patch, same as previous one, but better formatted patch file

Rejecting patch 73790 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 73790]" exit_code: 2
Last 500 characters of output:
62.
Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 2
Parsed 3 diffs from patch file(s).
patching file WebCore/ChangeLog
patch: **** unexpected end of file in patch
patching file WebCore/inspector/ScriptCallFrame.cpp
patching file WebCore/inspector/ScriptCallStack.cpp

Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 2

Full output: http://queues.webkit.org/results/5902001

Thanks Andreas for taking a look here. 
I am not sure what exactly the error info from commit-bot mean.
And I can build everything locally without any trouble.
Any suggestions? Thanks!

[Andreas Kling]

This was fixed by someone else in <http://trac.webkit.org/changeset/71981>, closing.

Next time please upload undoctored patches so commit-queue won't choke :-)

*** This bug has been marked as a duplicate of bug 49500 ***