Bug 49443 - cpp.py needs some tidying.
Summary: cpp.py needs some tidying.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-12 07:16 PST by David Levin
Modified: 2010-11-12 10:21 PST (History)
3 users (show)

See Also:


Attachments
Patch (4.34 KB, patch)
2010-11-12 07:19 PST, David Levin
abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2010-11-12 07:16:52 PST
It probably could use more than what I did, but I just adjusted an area where I've been working.
Comment 1 David Levin 2010-11-12 07:19:02 PST
Created attachment 73741 [details]
Patch
Comment 2 Adam Barth 2010-11-12 10:07:48 PST
Comment on attachment 73741 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73741&action=review

Looks good, but there's a typo in you ChangeLog.  >:-)

> WebKitTools/ChangeLog:9
> +          Fix parametere ordering for iteratively_replace_matches_with_char

parametere ?

> WebKitTools/Scripts/webkitpy/style/checkers/cpp.py:1205
> -        if not body_found:
> +        else:

Woah
Comment 3 David Levin 2010-11-12 10:21:06 PST
(In reply to comment #2)
> (From update of attachment 73741 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=73741&action=review
> 
> Looks good, but there's a typo in you ChangeLog.  >:-)

I can't believe you cq- for that! Oh wait a minute....

Fixed and committed. :)

http://trac.webkit.org/changeset/71926