WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
49426
KeyboardEvent::keyIdentifier() should return "const String&"
https://bugs.webkit.org/show_bug.cgi?id=49426
Summary
KeyboardEvent::keyIdentifier() should return "const String&"
Kent Tamura
Reported
2010-11-11 22:30:30 PST
Darin wrote:
> > WebCore/html/InputType.cpp:278 > > + String key = static_cast<KeyboardEvent*>(event)->keyIdentifier(); > > It would be better if keyIdentifier returned a const String& and this local variable was also const String&. There’s no need to churn the reference count just to check string equality.
Attachments
Patch
(6.28 KB, patch)
2010-11-11 22:34 PST
,
Kent Tamura
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kent Tamura
Comment 1
2010-11-11 22:34:22 PST
Created
attachment 73701
[details]
Patch
Andreas Kling
Comment 2
2010-11-12 04:43:20 PST
Comment on
attachment 73701
[details]
Patch You missed this one, please fix before landing. WebKit/mac/WebCoreSupport/WebEditorClient.mm:646: String key = event->keyIdentifier();
Kent Tamura
Comment 3
2010-11-14 21:20:44 PST
(In reply to
comment #2
)
> (From update of
attachment 73701
[details]
) > You missed this one, please fix before landing. > WebKit/mac/WebCoreSupport/WebEditorClient.mm:646: String key = event->keyIdentifier();
Thank you! I fixed it, and confirmed no other keyIndentifier() in WebKit/ directory. Committed as
r71995
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug