Darin wrote: > > WebCore/html/InputType.cpp:278 > > + String key = static_cast<KeyboardEvent*>(event)->keyIdentifier(); > > It would be better if keyIdentifier returned a const String& and this local variable was also const String&. There’s no need to churn the reference count just to check string equality.
Created attachment 73701 [details] Patch
Comment on attachment 73701 [details] Patch You missed this one, please fix before landing. WebKit/mac/WebCoreSupport/WebEditorClient.mm:646: String key = event->keyIdentifier();
(In reply to comment #2) > (From update of attachment 73701 [details]) > You missed this one, please fix before landing. > WebKit/mac/WebCoreSupport/WebEditorClient.mm:646: String key = event->keyIdentifier(); Thank you! I fixed it, and confirmed no other keyIndentifier() in WebKit/ directory. Committed as r71995.