RESOLVED FIXED49420
Clean up syntax/reference error throw. 
https://bugs.webkit.org/show_bug.cgi?id=49420
Summary Clean up syntax/reference error throw.
Gavin Barraclough
Reported 2010-11-11 17:44:18 PST
Some errors detected at compile time are thrown at runtime. We currently do so using a op_new_error/op_throw bytecode pair. This is not ideal. op_throw is used for explicit user throw statements, and has different requirements in terms or meta data attached to the exception (controlled by the explicitThrow parameter passed to Interpreter::throwException). To work around this, op_new_error has to add the meta data at an early stage, which is unlike other VM exceptions being raised. We can simplify this and bring into line with other exception behaviour by changing new_error from just allocating an Exception instance to also throwing it – but as a regular VM throw, correctly passing explicitThrow as false.
Attachments
The patch (25.45 KB, patch)
2010-11-11 17:46 PST, Gavin Barraclough 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2010-11-11 17:46:58 PST
Created attachment 73687 [details] The patch
Gavin Barraclough
Comment 2 2010-11-11 19:06:29 PST
committed r71878
Note You need to log in before you can comment on or make changes to this bug.