Bug 49405 – [chromium] Support letter spacing and fix whitespace wrapping on linux

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[James Simonsen]

[chromium] Support letter spacing and fix whitespace wrapping on linux

[James Simonsen]

Created attachment 73663 [details]
Patch

[James Simonsen]

Hi Adam,

You seem to be most familiar with this code. Could I bother you to LGTM it and then I'll find an R+? Thanks.

[Adam Langley]

Comment on attachment 73663 [details]
Patch

LGTM.

Thanks for this! Some WK folks might question the duplication of code in setGlyphXPositions but, in my opinion, it's below the granularity of a function in C, so it's fine by me.

[Tony Chang]

Comment on attachment 73663 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73663&action=review

> WebCore/platform/graphics/chromium/FontLinux.cpp:500
> +            if (i+1 >= m_item.num_glyphs || m_item.attributes[i+1].clusterStart)

Nit: spaces around the +s.

[James Simonsen]

Created attachment 73669 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 73669 [details]:

fast/workers/storage/use-same-database-in-page-and-workers.html

Please file bugs against the tests.  These tests were authored by [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 73669 [details]
Patch

Clearing flags on attachment: 73669

Committed r71887: <http://trac.webkit.org/changeset/71887>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.