Bug 49400 – [GTK] Changing any GNUmakefile.am in the source tree forces a rebuld of the DOM bindings and WebKit API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Martin Robinson]

webkitenums.cpp has a dependency on the final generated GNUmakefile, so modifying any GNUmakefile.am , forces the WebKit layer and the DOM bindings to rebuild. This make modifying something like WebCore/GNUmakefile a more expensive operation than it needs to be.

[Martin Robinson]

Created attachment 73640 [details]
Patch for this issue

[Gustavo Noronha (kov)]

Comment on attachment 73640 [details]
Patch for this issue

View in context: https://bugs.webkit.org/attachment.cgi?id=73640&action=review

> GNUmakefile.am:-29
> -	--enable-introspection	\

Just remember to undo this change! The rest looks fine =)

[Martin Robinson]

Committed r72275: <http://trac.webkit.org/changeset/72275>

[Ravi Phaneendra Kasibhatla]

Robinson,
Just an after thought. Wouldn't it be better to even move the libJavaScriptCore_la changes to JavaScriptCore/GNUmakefile.am? 

It makes the root GNUmakefile.am completely independent of any target specific changes and retains only the global flags and variables which are applicable for all the individual targets.

[Martin Robinson]

(In reply to comment #4)
> Robinson,
> Just an after thought. Wouldn't it be better to even move the libJavaScriptCore_la changes to JavaScriptCore/GNUmakefile.am? 
> 
> It makes the root GNUmakefile.am completely independent of any target specific changes and retains only the global flags and variables which are applicable for all the individual targets.

Yep! I had planned to do that in a later patch.