Bug 49363 - fix missing 'pid' argument for http lockfile checking on win32
Summary: fix missing 'pid' argument for http lockfile checking on win32
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-10 20:04 PST by Dirk Pranke
Modified: 2010-11-11 14:52 PST (History)
8 users (show)

See Also:


Attachments
Patch (1.48 KB, patch)
2010-11-10 20:04 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-11-10 20:04:17 PST
fix missing 'pid' argument for http lockfile checking on win32
Comment 1 Dirk Pranke 2010-11-10 20:04:51 PST
Created attachment 73574 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-11-10 21:43:11 PST
Comment on attachment 73574 [details]
Patch

Makes sense. :)  Can't we test this though?  Or was it already failing a test on win32?
Comment 3 Dirk Pranke 2010-11-11 13:33:16 PST
I haven't actually tried this on windows, but there is an existing test in executive_unittest that should've keeled over. Of course, we can't run much of test-webkitpy on windows, so this test may not actually be running. I will verify it locally.
Comment 4 Michael Nordman 2010-11-11 13:37:49 PST
I've run this patch on windows. Definitely fixes a problem with starting the http server when running layout tests.
Comment 5 Dirk Pranke 2010-11-11 13:56:56 PST
Okay, I've verified that the test did fail prior to the patch and does pass post-patch. Given that Michael has verified that it actually fixes NRWT as well :), we're good to go.
Comment 6 Dirk Pranke 2010-11-11 14:52:50 PST
Comment on attachment 73574 [details]
Patch

Clearing flags on attachment: 73574

Committed r71854: <http://trac.webkit.org/changeset/71854>
Comment 7 Dirk Pranke 2010-11-11 14:52:55 PST
All reviewed patches have been landed.  Closing bug.