Add Event and EventListener hooks for JavaScriptAudioNode and AudioProcessingEvent
Created attachment 73565 [details] Patch
Comment on attachment 73565 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73565&action=review This looks good overall. r- for the unrelated header reorderings. If check-webkit-style is complaining then try webkit-patch upload to upload your next patch, which I believe will only run the style checker against the changed portions of your diff. > WebCore/bindings/js/JSEventTarget.cpp:66 > -#include "SVGElementInstance.h" > #include "JSSVGElementInstance.h" > +#include "SVGElementInstance.h" This looks like an unrelated change that should go in a separate patch. > WebCore/bindings/js/JSEventTarget.cpp:98 > -#include "JSFileReader.h" > #include "FileReader.h" > +#include "JSFileReader.h" This looks like an unrelated change that should go in a separate patch.
Created attachment 73670 [details] Patch
Thanks for the tip about check-webkit-style. I removed the other un-related change and webkit-patch upload did not complain.
Comment on attachment 73670 [details] Patch Looks good to me.
Comment on attachment 73670 [details] Patch Clearing flags on attachment: 73670 Committed r72048: <http://trac.webkit.org/changeset/72048>
All reviewed patches have been landed. Closing bug.