Bug 49357 - Add Event and EventListener hooks for JavaScriptAudioNode and AudioProcessingEvent
Summary: Add Event and EventListener hooks for JavaScriptAudioNode and AudioProcessing...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-10 17:59 PST by Chris Rogers
Modified: 2010-11-15 17:22 PST (History)
2 users (show)

See Also:


Attachments
Patch (7.30 KB, patch)
2010-11-10 18:07 PST, Chris Rogers
no flags Details | Formatted Diff | Diff
Patch (6.99 KB, patch)
2010-11-11 15:07 PST, Chris Rogers
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2010-11-10 17:59:05 PST
Add Event and EventListener hooks for JavaScriptAudioNode and AudioProcessingEvent
Comment 1 Chris Rogers 2010-11-10 18:07:35 PST
Created attachment 73565 [details]
Patch
Comment 2 Kenneth Russell 2010-11-11 14:52:55 PST
Comment on attachment 73565 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73565&action=review

This looks good overall. r- for the unrelated header reorderings. If check-webkit-style is complaining then try webkit-patch upload to upload your next patch, which I believe will only run the style checker against the changed portions of your diff.

> WebCore/bindings/js/JSEventTarget.cpp:66
> -#include "SVGElementInstance.h"
>  #include "JSSVGElementInstance.h"
> +#include "SVGElementInstance.h"

This looks like an unrelated change that should go in a separate patch.

> WebCore/bindings/js/JSEventTarget.cpp:98
> -#include "JSFileReader.h"
>  #include "FileReader.h"
> +#include "JSFileReader.h"

This looks like an unrelated change that should go in a separate patch.
Comment 3 Chris Rogers 2010-11-11 15:07:14 PST
Created attachment 73670 [details]
Patch
Comment 4 Chris Rogers 2010-11-11 15:09:11 PST
Thanks for the tip about check-webkit-style.  I removed the other un-related change and webkit-patch upload did not complain.
Comment 5 Kenneth Russell 2010-11-15 14:46:33 PST
Comment on attachment 73670 [details]
Patch

Looks good to me.
Comment 6 WebKit Commit Bot 2010-11-15 17:22:25 PST
Comment on attachment 73670 [details]
Patch

Clearing flags on attachment: 73670

Committed r72048: <http://trac.webkit.org/changeset/72048>
Comment 7 WebKit Commit Bot 2010-11-15 17:22:30 PST
All reviewed patches have been landed.  Closing bug.