RESOLVED FIXED 49357
Add Event and EventListener hooks for JavaScriptAudioNode and AudioProcessingEvent 
https://bugs.webkit.org/show_bug.cgi?id=49357
Summary Add Event and EventListener hooks for JavaScriptAudioNode and AudioProcessing...
Chris Rogers
Reported 2010-11-10 17:59:05 PST
Add Event and EventListener hooks for JavaScriptAudioNode and AudioProcessingEvent
Attachments
Patch (7.30 KB, patch)
2010-11-10 18:07 PST, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Patch (6.99 KB, patch)
2010-11-11 15:07 PST, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2010-11-10 18:07:35 PST
Created attachment 73565 [details] Patch
Kenneth Russell
Comment 2 2010-11-11 14:52:55 PST
Comment on attachment 73565 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73565&action=review This looks good overall. r- for the unrelated header reorderings. If check-webkit-style is complaining then try webkit-patch upload to upload your next patch, which I believe will only run the style checker against the changed portions of your diff. > WebCore/bindings/js/JSEventTarget.cpp:66 > -#include "SVGElementInstance.h" > #include "JSSVGElementInstance.h" > +#include "SVGElementInstance.h" This looks like an unrelated change that should go in a separate patch. > WebCore/bindings/js/JSEventTarget.cpp:98 > -#include "JSFileReader.h" > #include "FileReader.h" > +#include "JSFileReader.h" This looks like an unrelated change that should go in a separate patch.
Chris Rogers
Comment 3 2010-11-11 15:07:14 PST
Created attachment 73670 [details] Patch
Chris Rogers
Comment 4 2010-11-11 15:09:11 PST
Thanks for the tip about check-webkit-style. I removed the other un-related change and webkit-patch upload did not complain.
Kenneth Russell
Comment 5 2010-11-15 14:46:33 PST
Comment on attachment 73670 [details] Patch Looks good to me.
WebKit Commit Bot
Comment 6 2010-11-15 17:22:25 PST
Comment on attachment 73670 [details] Patch Clearing flags on attachment: 73670 Committed r72048: <http://trac.webkit.org/changeset/72048>
WebKit Commit Bot
Comment 7 2010-11-15 17:22:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.