Bug 49347 - Push m_viewSize down to DrawingAreaProxy base class
Summary: Push m_viewSize down to DrawingAreaProxy base class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-10 14:40 PST by Simon Fraser (smfr)
Modified: 2010-11-10 16:56 PST (History)
7 users (show)

See Also:

Attachments
Patch (9.37 KB, patch)
2010-11-10 14:52 PST, Simon Fraser (smfr) 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-11-10 14:40:43 PST 
Some cleanup coming.
Comment 1 Simon Fraser (smfr) 2010-11-10 14:52:49 PST 
Created attachment 73544 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-11-10 14:55:24 PST 
Comment on attachment 73544 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73544&action=review

> WebKit2/UIProcess/DrawingAreaProxy.h:57
> +    WebCore::IntSize size() const { return m_size; }

This can return a reference to const.

> WebKit2/UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:50
> +    IntSize viewSize = size();

This can be a reference to const.
Comment 3 Early Warning System Bot 2010-11-10 15:01:35 PST 
Attachment 73544 [details] did not build on qt:
Build output: http://queues.webkit.org/results/5511096
Comment 4 Simon Fraser (smfr) 2010-11-10 16:23:06 PST 
http://trac.webkit.org/changeset/71780
Comment 5 WebKit Review Bot 2010-11-10 16:56:03 PST 
http://trac.webkit.org/changeset/71780 might have broken Qt Linux Release
The following tests are not passing:
svg/animations/repeatDur-zero.xhtml