Bug 49338 - plugins/npruntime/enumerate.html shouldn't depend on object enumeration order
Summary: plugins/npruntime/enumerate.html shouldn't depend on object enumeration order
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-10 12:44 PST by Tony Chang
Modified: 2010-11-10 16:22 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.62 KB, patch)
2010-11-10 12:47 PST, Tony Chang 		no flags Details | Formatted Diff | Diff
Patch for landing (3.35 KB, patch)
2010-11-10 13:58 PST, Tony Chang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-11-10 12:44:45 PST 
plugins/npruntime/enumerate.html shouldn't depend on object enumeration order
Comment 1 Tony Chang 2010-11-10 12:47:08 PST 
Created attachment 73528 [details]
Patch
Comment 2 Darin Adler 2010-11-10 13:14:54 PST 
Comment on attachment 73528 [details]
Patch

I suggest sorting as a solution to this sort of thing, rather than the set equality approach.
Comment 3 Tony Chang 2010-11-10 13:58:05 PST 
Created attachment 73537 [details]
Patch for landing
Comment 4 Tony Chang 2010-11-10 13:58:45 PST 
(In reply to comment #2)
> (From update of attachment 73528 [details])
> I suggest sorting as a solution to this sort of thing, rather than the set equality approach.

Good idea.  Done.
Comment 5 WebKit Commit Bot 2010-11-10 15:06:52 PST 
The commit-queue encountered the following flaky tests while processing attachment 73537 [details]:

compositing/iframes/overlapped-nested-iframes.html

Please file bugs against the tests.  These tests were authored by simon.fraser@apple.com.  The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2010-11-10 15:08:25 PST 
Comment on attachment 73537 [details]
Patch for landing

Clearing flags on attachment: 73537

Committed r71776: <http://trac.webkit.org/changeset/71776>
Comment 7 WebKit Commit Bot 2010-11-10 15:08:30 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Review Bot 2010-11-10 16:22:11 PST 
http://trac.webkit.org/changeset/71776 might have broken Leopard Intel Debug (Tests)