Bug 49336 - [chromium] Clean up gfx::GetGLImplementation calls in WebGraphicsContext3DDefaultImpl
Summary: [chromium] Clean up gfx::GetGLImplementation calls in WebGraphicsContext3DDef...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Zhenyao Mo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-10 12:30 PST by Kenneth Russell
Modified: 2010-11-12 13:39 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.84 KB, patch)
2010-11-10 12:33 PST, Kenneth Russell 		jamesr: review+
kbr: commit-queue-
Details | Formatted Diff | Diff
patch: simple fix for the regression (1.24 KB, patch)
2010-11-12 11:08 PST, Zhenyao Mo 		kling: review+
zmo: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-11-10 12:30:38 PST 
In https://bugs.webkit.org/show_bug.cgi?id=48282 I missed a few places where m_isGLES2 should be tested instead of calling gfx::GetGLImplementation().
Comment 1 Kenneth Russell 2010-11-10 12:33:48 PST 
Created attachment 73524 [details]
Patch
Comment 2 James Robinson 2010-11-10 12:38:41 PST 
Comment on attachment 73524 [details]
Patch

R=me
Comment 3 Kenneth Russell 2010-11-10 19:10:01 PST 
Committed r71793: <http://trac.webkit.org/changeset/71793>
Comment 4 Zhenyao Mo 2010-11-12 10:54:51 PST 
There is a regression in this patch that causes worlds of webgl render incorrectly in in-process-webgl
Comment 5 Zhenyao Mo 2010-11-12 11:08:26 PST 
Created attachment 73762 [details]
patch: simple fix for the regression

point-size.html should have detected this regression, only unfortunately due to mesa backend issues, this test is ignored in chromium bots.
Comment 6 Andreas Kling 2010-11-12 13:30:31 PST 
Comment on attachment 73762 [details]
patch: simple fix for the regression

r=me
Comment 7 Zhenyao Mo 2010-11-12 13:39:47 PST 
Committed r71942: <http://trac.webkit.org/changeset/71942>