Bug 49318 - [Qt] clean canvas layout tests skipped file
Summary: [Qt] clean canvas layout tests skipped file
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
Keywords: Qt
Depends on:
Reported: 2010-11-10 07:03 PST by qi
Modified: 2010-11-11 05:07 PST (History)
3 users (show)

See Also:

patch (2.08 KB, patch)
2010-11-10 07:09 PST, qi
no flags Details | Formatted Diff | Diff
patch2 (2.09 KB, patch)
2010-11-10 08:13 PST, qi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description qi 2010-11-10 07:03:30 PST
Check the canvas layout skipped list.
Comment 1 qi 2010-11-10 07:09:55 PST
Created attachment 73496 [details]

Remove 3 test cases from skipped.
Comment 2 Chang Shu 2010-11-10 07:15:14 PST
It seems the current qt buildbot is still using qt4.6.2. Not sure if these tests will pass there. But I was told it will switch to qt4.7 soon.
Comment 3 qi 2010-11-10 08:13:25 PST
Created attachment 73500 [details]

update ChangeLog
Comment 4 Csaba Osztrogonác 2010-11-11 04:49:28 PST
Comment on attachment 73500 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=73500&action=review

I'll land it manually

> LayoutTests/platform/qt/Skipped:-5065
> -canvas/philip/tests/2d.path.quadraticCurveTo.scaled.html

This testcase fails on the bot with Qt 4.6.3, but the others pass.
Comment 5 Csaba Osztrogonác 2010-11-11 05:03:16 PST
Landed in http://trac.webkit.org/changeset/71807
Comment 6 Csaba Osztrogonác 2010-11-11 05:07:21 PST
Please add the URL of the bug to the ChangeLog next time: https://bugs.webkit.org/show_bug.cgi?id=49318