WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 49302
Add a test for form submission by <input type=image>
https://bugs.webkit.org/show_bug.cgi?id=49302
Summary
Add a test for form submission by <input type=image>
Kent Tamura
Reported
2010-11-09 23:41:05 PST
Add a test for form submission by <input type=image> We have no tests about it!
Attachments
Patch
(5.68 KB, patch)
2010-11-09 23:42 PST
,
Kent Tamura
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kent Tamura
Comment 1
2010-11-09 23:42:42 PST
Created
attachment 73461
[details]
Patch
Shinichiro Hamaji
Comment 2
2010-11-10 00:12:06 PST
Comment on
attachment 73461
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=73461&action=review
Adding more tests is nice :) I've put two minor comments, please apply them if you like.
> LayoutTests/fast/forms/input-image-submit.html:37 > + gc();
I think the reason why we need to run gc here isn't so clear. Could you write a few comments?
> LayoutTests/fast/forms/input-image-submit.html:72 > + testFailed('Normal submission failed: ' + query);
I'd add a function which calls both testFailed and notifyDone.
Kent Tamura
Comment 3
2010-11-11 00:27:29 PST
Thanks for reviewing. I have committed the patch with the following changes as
http://trac.webkit.org/changeset/71799
(In reply to
comment #2
)
> > LayoutTests/fast/forms/input-image-submit.html:37 > > + gc(); > > I think the reason why we need to run gc here isn't so clear. Could you write a few comments?
I added a comment.
> > LayoutTests/fast/forms/input-image-submit.html:72 > > + testFailed('Normal submission failed: ' + query); > > I'd add a function which calls both testFailed and notifyDone.
I made a function for it.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug