RESOLVED FIXED 49287
[Qt] crash when attempting to add a JS object 
https://bugs.webkit.org/show_bug.cgi?id=49287
Summary [Qt] crash when attempting to add a JS object
Sam Magnuson
Reported 2010-11-09 16:43:42 PST
There is a crash due to a null pointer dereference. I noticed this with a crash in: LayoutTests/fast/frames/sandboxed-iframe-plugins.html with the fix this test still doesn't pass, but at least it no longer crashes :)
Attachments
Patch (1.20 KB, patch)
2010-11-09 16:47 PST, Sam Magnuson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Magnuson
Comment 1 2010-11-09 16:47:15 PST
Created attachment 73435 [details] Patch
Andreas Kling
Comment 2 2010-11-20 21:34:35 PST
Comment on attachment 73435 [details] Patch Nice catch, root will be null here if scripts are sandboxed. r=me
WebKit Commit Bot
Comment 3 2010-11-20 22:02:16 PST
The commit-queue encountered the following flaky tests while processing attachment 73435 [details]: fast/workers/storage/use-same-database-in-page-and-workers.html Please file bugs against the tests. These tests were authored by dumi@chromium.org. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2010-11-20 22:03:24 PST
Comment on attachment 73435 [details] Patch Clearing flags on attachment: 73435 Committed r72491: <http://trac.webkit.org/changeset/72491>
WebKit Commit Bot
Comment 5 2010-11-20 22:03:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.