Bug 49287 - [Qt] crash when attempting to add a JS object
Summary: [Qt] crash when attempting to add a JS object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-09 16:43 PST by Sam Magnuson
Modified: 2010-11-20 22:03 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.20 KB, patch)
2010-11-09 16:47 PST, Sam Magnuson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Magnuson 2010-11-09 16:43:42 PST 
There is a crash due to a null pointer dereference. I noticed this with a crash in:

LayoutTests/fast/frames/sandboxed-iframe-plugins.html

with the fix this test still doesn't pass, but at least it no longer crashes :)
Comment 1 Sam Magnuson 2010-11-09 16:47:15 PST 
Created attachment 73435 [details]
Patch
Comment 2 Andreas Kling 2010-11-20 21:34:35 PST 
Comment on attachment 73435 [details]
Patch

Nice catch, root will be null here if scripts are sandboxed.
r=me
Comment 3 WebKit Commit Bot 2010-11-20 22:02:16 PST 
The commit-queue encountered the following flaky tests while processing attachment 73435 [details]:

fast/workers/storage/use-same-database-in-page-and-workers.html

Please file bugs against the tests.  These tests were authored by dumi@chromium.org.  The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2010-11-20 22:03:24 PST 
Comment on attachment 73435 [details]
Patch

Clearing flags on attachment: 73435

Committed r72491: <http://trac.webkit.org/changeset/72491>
Comment 5 WebKit Commit Bot 2010-11-20 22:03:29 PST 
All reviewed patches have been landed.  Closing bug.