Bug 49275 – Need WebKit2 mechanism for getting the visible page text

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Sam Weinig]

Need WebKit2 mechanism for getting the visible page text

[Sam Weinig]

<rdar://problem/8646928>

[Sam Weinig]

Created attachment 73408 [details]
Patch

[Darin Adler]

Comment on attachment 73408 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73408&action=review

> WebKit2/UIProcess/WebPageProxy.cpp:74
> +void invalidateCallbackMap(HashMap<uint64_t, RefPtr<T> >& map)

Could just use T in this template in the places you use RefPtr<T>. Would read nicer and work just as well.

> WebKit2/UIProcess/API/C/WKPage.cpp:333
> +void WKPageGetContentsAsString(WKPageRef pageRef, void *context, WKPageGetContentsAsStringFunction callback)

Should be void* instead of void *.

> WebKit2/WebProcess/WebPage/WebFrame.cpp:248
> +            WebFrame* webFrame = static_cast<WebFrameLoaderClient*>(child->loader()->client())->webFrame();
> +            builder.append(webFrame->contentsAsString());

Not sure this needs a local variable for webFrame.

> WebKit2/WebProcess/WebPage/WebFrame.cpp:250
> +            if (child->tree()->nextSibling())
> +                builder.append(' ');

I would suggest:

    if (!builder.isEmpty())
        builder.append(' ');

at the start of the loop instead of this code at the end of the loop.

> WebKit2/WebProcess/WebPage/WebFrame.cpp:254
> +        
> +        // FIXME: It may make sense to use toStringPreserveCapacity() here.
> +        return builder.toString();

The blank line here makes the paragraphing a little strange.

[Sam Weinig]

Landed in 71678.