Bug 49272 - HTML5 Ruby support should be mandatory feature
Summary: HTML5 Ruby support should be mandatory feature
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 48755
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-09 12:39 PST by Csaba Osztrogonác
Modified: 2010-11-10 10:44 PST (History)
4 users (show)

See Also:


Attachments
proposed patch (33.07 KB, patch)
2010-11-09 13:08 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
proposed patch v2 (33.67 KB, patch)
2010-11-09 14:10 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
proposed patch v3 (34.07 KB, patch)
2010-11-10 00:48 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
proposed patch v4 (33.61 KB, patch)
2010-11-10 07:48 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
proposed patch v5 (35.97 KB, patch)
2010-11-10 09:43 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2010-11-09 12:39:52 PST
Ruby is a core part of HTML5, it should be a mandatory feature and not optional.
Comment 1 Csaba Osztrogonác 2010-11-09 13:08:26 PST
Created attachment 73404 [details]
proposed patch
Comment 2 Build Bot 2010-11-09 13:51:29 PST
Attachment 73404 [details] did not build on win:
Build output: http://queues.webkit.org/results/5470061
Comment 3 Csaba Osztrogonác 2010-11-09 14:10:40 PST
Created attachment 73412 [details]
proposed patch v2

I touched WebCorePrefix.h to make Windows build happy:

3>..\html\parser\HTMLViewSourceParser.cpp : error C2220: warning treated as error - no 'object' file generated
3>..\html\parser\HTMLViewSourceParser.cpp : warning C4651: '/DENABLE_RUBY' specified for precompiled header but not for current compile
Comment 4 Build Bot 2010-11-09 16:25:30 PST
Attachment 73412 [details] did not build on win:
Build output: http://queues.webkit.org/results/5531074
Comment 5 Csaba Osztrogonác 2010-11-10 00:48:06 PST
Created attachment 73468 [details]
proposed patch v3

I touched config.h too to make Windows build happy. I hope it will work.
Comment 6 Build Bot 2010-11-10 02:25:47 PST
Attachment 73468 [details] did not build on win:
Build output: http://queues.webkit.org/results/5552069
Comment 7 Csaba Osztrogonác 2010-11-10 02:39:30 PST
I have no idea how can I make MSVC to update all precompiled header. :(
Could you give me a hint what should I do?
Comment 8 Adam Roben (:aroben) 2010-11-10 04:53:15 PST
(In reply to comment #7)
> I have no idea how can I make MSVC to update all precompiled header. :(
> Could you give me a hint what should I do?

Touching wtf/Platform.h should do it, though unfortunately that will make all ports do a clean build instead of just Windows. We really need to fix bug 48755!
Comment 9 Csaba Osztrogonác 2010-11-10 07:48:28 PST
Created attachment 73499 [details]
proposed patch v4

Touch Platform.h.
Comment 10 Build Bot 2010-11-10 09:07:29 PST
Attachment 73499 [details] did not build on win:
Build output: http://queues.webkit.org/results/5466084
Comment 11 Csaba Osztrogonác 2010-11-10 09:43:48 PST
Created attachment 73502 [details]
proposed patch v5

Touch the following headers:

- JavaScriptCore/JavaScriptCorePrefix.h
- WebCore/WebCorePrefix.h
- WebKit/win/WebKitPrefix.h 
- WebKit2/WebKit2Prefix.h
Comment 12 Dave Hyatt 2010-11-10 10:34:54 PST
Comment on attachment 73502 [details]
proposed patch v5

r=me. Yay!  Thanks for doing this.
Comment 13 Csaba Osztrogonác 2010-11-10 10:44:08 PST
Comment on attachment 73502 [details]
proposed patch v5

Clearing flags on attachment: 73502

Committed r71754: <http://trac.webkit.org/changeset/71754>
Comment 14 Csaba Osztrogonác 2010-11-10 10:44:19 PST
All reviewed patches have been landed.  Closing bug.