CLOSED WORKSFORME 49267
Review page mentions double-click to add comment, but that doesn't work any more 
https://bugs.webkit.org/show_bug.cgi?id=49267
Summary Review page mentions double-click to add comment, but that doesn't work any more
John Sullivan
Reported 2010-11-09 11:48:30 PST
At the top of the review page it says: Double-click a line or select line numbers to add a comment. But the double-click technique no longer works. The text at the top of the review page needs to be updated. It seems like r71607 was intended to change this text, but the old text still appears. Maybe there's a cached version somewhere that needs to be updated?
Attachments
Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-11-09 17:26:07 PST
I removed the text in a followup commit. You might need to clear your cache to see the new text.
John Sullivan
Comment 2 2010-11-09 17:36:27 PST
I do see the new text now, but it wasn't there this morning when I filed this (and others could repro). Anyway, seems fine now, so closing.
Adam Barth
Comment 3 2010-11-09 18:03:40 PST
The cache headers on code-review.js seem to be set pretty aggressively. When I make compatibility breaking changes, I bump the version number in the URL. For this change, it didn't seem like much of a rush, so I didn't bump the version number.
Note You need to log in before you can comment on or make changes to this bug.