WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
49266
Move the find page overlay code to FindController
https://bugs.webkit.org/show_bug.cgi?id=49266
Summary
Move the find page overlay code to FindController
Anders Carlsson
Reported
2010-11-09 11:30:44 PST
Move the find page overlay code to FindController
Attachments
Patch
(13.90 KB, patch)
2010-11-09 11:32 PST
,
Anders Carlsson
sullivan
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2010-11-09 11:32:08 PST
Created
attachment 73394
[details]
Patch
John Sullivan
Comment 2
2010-11-09 11:39:40 PST
Comment on
attachment 73394
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=73394&action=review
> WebKit2/WebProcess/WebPage/FindController.h:63 > + // FIXME: This should be private.
It's not clear what "This" is here. It's also worth mentioning why it can't currently be private.
Anders Carlsson
Comment 3
2010-11-09 12:04:26 PST
Committed
r71665
: <
http://trac.webkit.org/changeset/71665
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug