Bug 49266 - Move the find page overlay code to FindController
Summary: Move the find page overlay code to FindController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-09 11:30 PST by Anders Carlsson
Modified: 2010-11-09 12:04 PST (History)
0 users

See Also:

Attachments
Patch (13.90 KB, patch)
2010-11-09 11:32 PST, Anders Carlsson 		sullivan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-11-09 11:30:44 PST 
Move the find page overlay code to FindController
Comment 1 Anders Carlsson 2010-11-09 11:32:08 PST 
Created attachment 73394 [details]
Patch
Comment 2 John Sullivan 2010-11-09 11:39:40 PST 
Comment on attachment 73394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73394&action=review

> WebKit2/WebProcess/WebPage/FindController.h:63
> +    // FIXME: This should be private.

It's not clear what "This" is here. It's also worth mentioning why it can't currently be private.
Comment 3 Anders Carlsson 2010-11-09 12:04:26 PST 
Committed r71665: <http://trac.webkit.org/changeset/71665>