Bug 49234 - gtk platform doesn't support link prefetch
Summary: gtk platform doesn't support link prefetch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-08 18:59 PST by Gavin Peters
Modified: 2010-11-09 05:35 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.30 KB, patch)
2010-11-08 19:03 PST, Gavin Peters 		no flags Details | Formatted Diff | Diff
Patch (2.34 KB, patch)
2010-11-08 20:05 PST, Gavin Peters 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Peters 2010-11-08 18:59:50 PST 
The configure script used for the GTK platform doesn't at present pass through the link prefetch feature in WebKit.  It probably should.
Comment 1 Gavin Peters 2010-11-08 19:03:44 PST 
Created attachment 73336 [details]
Patch
Comment 2 Gavin Peters 2010-11-08 19:06:19 PST 
Xan,

Can you look at this?  Manual testing shows that it works with build-webkit and ./configure, and prefetch validation sites show it working.
Comment 3 Xan Lopez 2010-11-08 19:43:28 PST 
Comment on attachment 73336 [details]
Patch

>+AM_CONDITIONAL([ENABLE_LINK_PREFETCH],[test "$enable_link_prefetch" = "yes"])

I think you only need this if you are going to use the variable in a makefile. Since you won't it's unneeded.

> 
> # Gtk conditionals
> AM_CONDITIONAL([ENABLE_INTROSPECTION],[test "$enable_introspection" = "yes"])
>@@ -1027,6 +1039,7 @@ Features:
>  XHTML-MP support                                         : $enable_xhtmlmp
>  XPATH support                                            : $enable_xpath
>  XSLT support                                             : $enable_xslt
>+ Link prefetch support                                    : $enable_link_prefetch

This should be in alphabetical order.

> GTK+ configuration:
>  GTK+ version                                             : $with_gtk
>  GDK target                                               : $with_target

r- for those reasons, thanks for the patch.
Comment 4 Gavin Peters 2010-11-08 20:05:47 PST 
Created attachment 73338 [details]
Patch
Comment 5 WebKit Commit Bot 2010-11-09 04:05:16 PST 
Comment on attachment 73338 [details]
Patch

Clearing flags on attachment: 73338

Committed r71620: <http://trac.webkit.org/changeset/71620>
Comment 6 WebKit Commit Bot 2010-11-09 04:05:20 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2010-11-09 05:35:02 PST 
http://trac.webkit.org/changeset/71620 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
fast/text/international/plane2.html