Bug 49232 - [chromium] Convert WebPerformance doubles to seconds
Summary: [chromium] Convert WebPerformance doubles to seconds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Gentilcore
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-08 18:37 PST by Tony Gentilcore
Modified: 2010-11-11 21:41 PST (History)
6 users (show)

See Also:

Attachments
Patch (5.08 KB, patch)
2010-11-08 18:39 PST, Tony Gentilcore 		no flags Details | Formatted Diff | Diff
Patch for landing (4.90 KB, patch)
2010-11-11 11:04 PST, Tony Gentilcore 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2010-11-08 18:37:30 PST 
[chromium] Convert WebPerformance doubles to seconds
Comment 1 Tony Gentilcore 2010-11-08 18:39:01 PST 
Created attachment 73332 [details]
Patch
Comment 2 WebKit Commit Bot 2010-11-11 09:31:26 PST 
Comment on attachment 73332 [details]
Patch

Rejecting patch 73332 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 73332]" exit_code: 2
Last 500 characters of output:
e/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Nate Chapin', u'--force']" exit_code: 1
Parsed 2 diffs from patch file(s).
patching file WebKit/chromium/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit/chromium/src/WebPerformance.cpp
Hunk #3 FAILED at 93.
1 out of 3 hunks FAILED -- saving rejects to file WebKit/chromium/src/WebPerformance.cpp.rej

Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Nate Chapin', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/5569077
Comment 3 Tony Gentilcore 2010-11-11 11:04:13 PST 
Created attachment 73628 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2010-11-11 20:55:56 PST 
Comment on attachment 73628 [details]
Patch for landing

Clearing flags on attachment: 73628

Committed r71883: <http://trac.webkit.org/changeset/71883>
Comment 5 WebKit Commit Bot 2010-11-11 20:56:02 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-11-11 21:41:04 PST 
http://trac.webkit.org/changeset/71883 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
fast/text/international/plane2.html