Bug 49223 - dump-as-markup conversion: editing/inserting/5607069-2.html and 5607069-3.html
Summary: dump-as-markup conversion: editing/inserting/5607069-2.html and 5607069-3.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-08 16:34 PST by Ryosuke Niwa
Modified: 2010-11-08 18:46 PST (History)
6 users (show)

See Also:

Attachments
converted tests (20.20 KB, patch)
2010-11-08 17:06 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
fixed the test description (20.19 KB, patch)
2010-11-08 17:49 PST, Ryosuke Niwa 		tkent: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2010-11-08 16:34:13 PST 
editing/inserting/5607069-2.html and editing/inserting/5607069-3.html should be dump-as-markup or dump-as-text tests.
We don't care so much about the rendering but we do care about the resultant DOM.
Comment 1 Ryosuke Niwa 2010-11-08 17:05:59 PST 
+tonikitoo & mrobinson since I'm attending to reenable these tests on Gtk & Qt as well.
Comment 2 Ryosuke Niwa 2010-11-08 17:06:15 PST 
Created attachment 73311 [details]
converted tests
Comment 3 Kent Tamura 2010-11-08 17:13:28 PST 
Comment on attachment 73311 [details]
converted tests

View in context: https://bugs.webkit.org/attachment.cgi?id=73311&action=review

> LayoutTests/editing/inserting/5607069-2.html:7
> +Markup.description("This tests for a bug where InsertLineBreak would insert a '\\n' instead of a <br> if the caret was set just before an input field. You should see two input fields each in its own paragraph below.");

We had better update the description text so that it mentions <br> between two <input>s.

> LayoutTests/editing/inserting/5607069-3.html:7
> +Markup.description("This tests for a bug in InsertParagraph where it would split and clone a <form> element in the same way it would a <p> or a <div>.  You should see two paragraphs below both inside the form (blue bordered) element.");

ditto. like "<br> between two x".
"blue border" seems to make no sense in dump-as-markup.
Comment 4 Ryosuke Niwa 2010-11-08 17:49:17 PST 
Created attachment 73324 [details]
fixed the test description
Comment 5 Ryosuke Niwa 2010-11-08 17:50:07 PST 
(In reply to comment #3)
> (From update of attachment 73311 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=73311&action=review
> 
> > LayoutTests/editing/inserting/5607069-2.html:7
> > +Markup.description("This tests for a bug where InsertLineBreak would insert a '\\n' instead of a <br> if the caret was set just before an input field. You should see two input fields each in its own paragraph below.");
> 
> We had better update the description text so that it mentions <br> between two <input>s.

Done.

> > LayoutTests/editing/inserting/5607069-3.html:7
> > +Markup.description("This tests for a bug in InsertParagraph where it would split and clone a <form> element in the same way it would a <p> or a <div>.  You should see two paragraphs below both inside the form (blue bordered) element.");
> 
> ditto. like "<br> between two x".
> "blue border" seems to make no sense in dump-as-markup.

Done.
Comment 6 Kent Tamura 2010-11-08 17:58:16 PST 
Comment on attachment 73324 [details]
fixed the test description

ok
Comment 7 Ryosuke Niwa 2010-11-08 18:46:00 PST 
Committed r71595: <http://trac.webkit.org/changeset/71595>