Bug 49223 – dump-as-markup conversion: editing/inserting/5607069-2.html and 5607069-3.html

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Ryosuke Niwa]

editing/inserting/5607069-2.html and editing/inserting/5607069-3.html should be dump-as-markup or dump-as-text tests.
We don't care so much about the rendering but we do care about the resultant DOM.

[Ryosuke Niwa]

+tonikitoo & mrobinson since I'm attending to reenable these tests on Gtk & Qt as well.

[Ryosuke Niwa]

Created attachment 73311 [details]
converted tests

[Kent Tamura]

Comment on attachment 73311 [details]
converted tests

View in context: https://bugs.webkit.org/attachment.cgi?id=73311&action=review

> LayoutTests/editing/inserting/5607069-2.html:7
> +Markup.description("This tests for a bug where InsertLineBreak would insert a '\\n' instead of a <br> if the caret was set just before an input field. You should see two input fields each in its own paragraph below.");

We had better update the description text so that it mentions <br> between two <input>s.

> LayoutTests/editing/inserting/5607069-3.html:7
> +Markup.description("This tests for a bug in InsertParagraph where it would split and clone a <form> element in the same way it would a <p> or a <div>.  You should see two paragraphs below both inside the form (blue bordered) element.");

ditto. like "<br> between two x".
"blue border" seems to make no sense in dump-as-markup.

[Ryosuke Niwa]

Created attachment 73324 [details]
fixed the test description

[Ryosuke Niwa]

(In reply to comment #3)
> (From update of attachment 73311 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=73311&action=review
> 
> > LayoutTests/editing/inserting/5607069-2.html:7
> > +Markup.description("This tests for a bug where InsertLineBreak would insert a '\\n' instead of a <br> if the caret was set just before an input field. You should see two input fields each in its own paragraph below.");
> 
> We had better update the description text so that it mentions <br> between two <input>s.

Done.

> > LayoutTests/editing/inserting/5607069-3.html:7
> > +Markup.description("This tests for a bug in InsertParagraph where it would split and clone a <form> element in the same way it would a <p> or a <div>.  You should see two paragraphs below both inside the form (blue bordered) element.");
> 
> ditto. like "<br> between two x".
> "blue border" seems to make no sense in dump-as-markup.

Done.

[Kent Tamura]

Comment on attachment 73324 [details]
fixed the test description

ok

[Ryosuke Niwa]

Committed r71595: <http://trac.webkit.org/changeset/71595>