http/tests/appcache/fallback.html and http/tests/appcache/offline-access.html are failing after http://trac.webkit.org/changeset/71562 It appears that, in chromium, ApplicationCacheHost::maybeLoadResource() can modify its ResourceRequest parameter. Before r71562, we then immediately called ResourceHandle::create() with the modified ResourceRequest. Now, the ResourceRequest changes are lost. I think that the call to maybeLoadResource() should be in ResourceLoader::start() instead of ResourceLoader::load(), similar to the call to DocumentLoader::scheduleArchiveLoad().
Created attachment 73303 [details] patch
Comment on attachment 73303 [details] patch this fix looks good to me
Comment on attachment 73303 [details] patch Ok. This change is slightly mysterious to me, but it seems ok.
> this fix looks good to me Thanks Michael.
Comment on attachment 73303 [details] patch Rejecting patch 73303 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 73303]" exit_code: 1 Traceback (most recent call last): File "./WebKitTools/Scripts/webkit-patch", line 70, in <module> main() File "./WebKitTools/Scripts/webkit-patch", line 63, in main from webkitpy.tool.main import WebKitPatch File "/Users/abarth/git/webkit-queue/WebKitTools/Scripts/webkitpy/tool/main.py", line 42, in <module> from webkitpy.common.net.rietveld import Rietveld ImportError: No module named rietveld Full output: http://queues.webkit.org/results/5569015
Comment on attachment 73303 [details] patch wah?
Comment on attachment 73303 [details] patch Clearing flags on attachment: 73303 Committed r71606: <http://trac.webkit.org/changeset/71606>
All reviewed patches have been landed. Closing bug.