Bug 49189 – We should add a build step to comment out or remove the lines unsetting TEMP and TMP in the .bashrc file

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Website

[Jessie Berlin]

The default .bashrc file (found at /etc/skel/.bashrc) has the following lines:

# TMP and TEMP are defined in the Windows environment.  Leaving
# them set to the default Windows temporary directory can have
# unexpected consequences.
unset TMP
unset TEMP

This is causing Windows builds to fail due to the changes made in http://trac.webkit.org/changeset/71532, which used %TEMP% and did not expect it to be the empty string.

Even if we roll out that patch, we actually want to pick up the TMP and TEMP paths from Windows (there is no good reason not to and those are the paths that will be used in released builds), so we should add a build step to comment out or remove those lines in the user's .bashrc file in tools.html.

[Jessie Berlin]

Created attachment 73252 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 73252 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73252&action=review

> WebKitSite/building/tools.html:59
> +<p>If you are using a bash shell, comment out or remove the lines from your .bashrc file (found at /home/[username]/.bashrc) that unset TMP and unset TEMP. Those lines would prevent picking up the Windows TMP and TEMP environment variables.</p>

I think it would be better to be more explicit. Something like:

Remove the following lines from <code>/home/[username]/.bashrc</code>:
<p class=code>unset TMP
unset TEMP</p>

[Jessie Berlin]

(In reply to comment #2)
> (From update of attachment 73252 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=73252&action=review
> 
> > WebKitSite/building/tools.html:59
> > +<p>If you are using a bash shell, comment out or remove the lines from your .bashrc file (found at /home/[username]/.bashrc) that unset TMP and unset TEMP. Those lines would prevent picking up the Windows TMP and TEMP environment variables.</p>
> 
> I think it would be better to be more explicit. Something like:
> 
> Remove the following lines from <code>/home/[username]/.bashrc</code>:
> <p class=code>unset TMP
> unset TEMP</p>

Changed to:

<p>Remove the following lines from <code>/home/[username]/.bashrc</code>:
<p class=code>
<div>unset TMP</div>
<div>unset TEMP</div>
</p>
Those lines would prevent picking up the Windows TMP and TEMP environment variables.</p>

Thanks for the review!

[Jessie Berlin]

Comment on attachment 73252 [details]
Patch

Commited in r71557
http://trac.webkit.org/changeset/71557