WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
49178
[Qt] ImageDecoderQt::internalDecodeSize() generate a failure when the size is empty
https://bugs.webkit.org/show_bug.cgi?id=49178
Summary
[Qt] ImageDecoderQt::internalDecodeSize() generate a failure when the size is...
Benjamin Poulain
Reported
2010-11-08 07:50:29 PST
The commit 05f617b823b43e85e24f476a94869a6698692a70 introduced
http://trac.webkit.org/changeset/49559
a change in the way the size of image is retrieved: @@ -171,7 +161,12 @@ void ImageDecoderQt::internalDecodeSize() { ASSERT(m_reader); + // If we have a QSize() something failed QSize size = m_reader->size(); + if (size.isEmpty()) + return failRead(); + + m_format = m_reader->format(); setSize(size.width(), size.height()); } With this change, custom plugins that do not report the size are not working anymore.
Attachments
Add attachment
proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1
2014-02-03 03:10:26 PST
=== Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at
https://bugreports.qt-project.org
and add a link to this issue. See
http://qt-project.org/wiki/ReportingBugsInQt
for additional guidelines.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug